Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the usage of packages keyword in cloud-init, to avoid auto upgrade of packages #1705

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Refactor the usage of packages keyword in cloud-init, to avoid auto upgrade of packages #1705

merged 4 commits into from
Sep 30, 2024

Conversation

srbarrios
Copy link
Member

What does this PR change?

Don't upgrade packages in the systems deployed in a SUMA/Uyuni test environment.

The cloud team added the module package-update-upgrade-install to SUSE cloud-init configuration. This triggers an not-desired update of packages in some of the systems part of our test environment.

This is triggered due to the usage of the keyword packages in our YAML file.

This PR replace the keyword packages by runcmd zypper in

Example:

packages: ["venv-salt-minion", "avahi", "nss-mdns", "qemu-guest-agent"]

runcmd:
  - zypper in venv-salt-minion avahi nss-mdns qemu-guest-agent

@srbarrios srbarrios requested a review from a team September 24, 2024 12:33
ktsamis
ktsamis requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need -y as well like some apt commands below

backend_modules/libvirt/host/user_data.yaml Outdated Show resolved Hide resolved
backend_modules/libvirt/host/user_data.yaml Outdated Show resolved Hide resolved
backend_modules/libvirt/host/user_data.yaml Outdated Show resolved Hide resolved
backend_modules/libvirt/host/user_data.yaml Outdated Show resolved Hide resolved
@srbarrios srbarrios force-pushed the revert-1704-revert-zypper-in-clout-init branch 2 times, most recently from 46e475d to 9ec7095 Compare September 24, 2024 14:36
@srbarrios
Copy link
Member Author

Something still wrong for Ubuntu2204 VM and SLES15SP4 BuildHost VM.
To be debugged.

@srbarrios srbarrios marked this pull request as draft September 24, 2024 14:54
Bischoff
Bischoff requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see remark about runcmd: sections

backend_modules/libvirt/host/user_data.yaml Show resolved Hide resolved
@Bischoff Bischoff mentioned this pull request Sep 26, 2024
Merged
2 tasks
@srbarrios srbarrios force-pushed the revert-1704-revert-zypper-in-clout-init branch from 9ec7095 to d32fab0 Compare September 30, 2024 07:47
@srbarrios srbarrios force-pushed the revert-1704-revert-zypper-in-clout-init branch from d32fab0 to b2007a2 Compare September 30, 2024 07:49
@srbarrios srbarrios self-assigned this Sep 30, 2024
@srbarrios srbarrios marked this pull request as ready for review September 30, 2024 09:58
ktsamis
ktsamis approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

Bischoff
Bischoff requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see nitpicks + 1 question

backend_modules/libvirt/host/user_data.yaml Outdated Show resolved Hide resolved
backend_modules/libvirt/host/user_data.yaml Show resolved Hide resolved
backend_modules/libvirt/host/user_data.yaml Show resolved Hide resolved
backend_modules/libvirt/host/user_data.yaml Show resolved Hide resolved
backend_modules/libvirt/host/user_data.yaml Show resolved Hide resolved
Bischoff
Bischoff approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the nitpick corrections

@srbarrios srbarrios merged commit 6f44783 into master Sep 30, 2024
2 checks passed
@srbarrios srbarrios deleted the revert-1704-revert-zypper-in-clout-init branch September 30, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamelessOne91 NamelessOne91 NamelessOne91 approved these changes

@Bischoff Bischoff Bischoff approved these changes

@ktsamis ktsamis ktsamis approved these changes

Assignees

@srbarrios srbarrios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srbarrios @Bischoff @ktsamis @NamelessOne91