Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu 24.04 #1707

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Sep 25, 2024

What does this PR change?

This PR adds support for Ubuntu 24.04. Part of https://github.com/SUSE/spacewalk/issues/23851.

Follow-up of #1691 from @nodeg (Dominik being absent).

For technical reasons it replaces packages: with runcmd: for cloud-init like in @srbarrios 's PR #1705.

TODO

  • wait for all Devel repos being available in OBS/IBS
  • DO NOT wait for SCC enabling products, as Ubuntu 24.04 is not published yet

Links

@Bischoff Bischoff mentioned this pull request Sep 25, 2024
2 tasks
@Bischoff Bischoff requested a review from nodeg September 25, 2024 13:16
Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I didn't check the urls and not sure if there's anything missing from another place but I don't think so.

@Bischoff
Copy link
Contributor Author

Bischoff commented Sep 25, 2024

Looks good to me, I didn't check the urls and not sure if there's anything missing from another place but I don't think so.

First tests show that the minion has its interface down:

2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether aa:b2:93:01:01:4b brd ff:ff:ff:ff:ff:ff
    altname enp0s3

Probably again a cloud-init pain... Will try to fix it tomorrow.

@Bischoff Bischoff force-pushed the add-ubuntu2404 branch 3 times, most recently from 5a39802 to 170b4cf Compare September 26, 2024 15:49
@Bischoff
Copy link
Contributor Author

After a lot of fixes, it seems to work.

Copy link
Contributor

@maximenoel8 maximenoel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

salt/controller/bashrc Show resolved Hide resolved
salt/mirror/etc/minima.yaml Outdated Show resolved Hide resolved
salt/mirror/etc/minima.yaml Outdated Show resolved Hide resolved
salt/mirror/etc/minima.yaml Outdated Show resolved Hide resolved
@Bischoff Bischoff force-pushed the add-ubuntu2404 branch 2 times, most recently from 5e44ea2 to 97fb916 Compare September 27, 2024 03:35
Copy link
Contributor

@maximenoel8 maximenoel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@Bischoff Bischoff merged commit cb6424e into uyuni-project:master Sep 27, 2024
2 of 3 checks passed
@Bischoff Bischoff deleted the add-ubuntu2404 branch October 4, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants