Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable salt service ONLY if auto_connect to master is true. #1710

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Oct 1, 2024

What does this PR change?

Don't start venv-salt-minion or salt-minion service when auto_connect_to_master is set to false.
The file master_configuration is only set when auto connect to master is true so it doesn't make sense to start salt minion service when file is not set.

@maximenoel8 maximenoel8 changed the title Enable salt service if auto_connect to master is true. Enable salt service ONLY if auto_connect to master is true. Oct 1, 2024
@maximenoel8 maximenoel8 requested a review from a team October 1, 2024 00:41
@maximenoel8 maximenoel8 self-assigned this Oct 1, 2024
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprising

Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maximenoel8 maximenoel8 merged commit 8770aab into uyuni-project:master Oct 2, 2024
2 checks passed
@maximenoel8 maximenoel8 deleted the minion_salt_service branch October 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants