Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move product version declaration to base #1713

Merged

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Oct 2, 2024

Context

Currently in BV, we need to copy/paste for all modules ( server, proxy and minions ) the product version variable.
The product version is always the same and don't bring information to minion or client modules.
After discussion, we want to declare the product version to only one place and the best place seems to be at the base module level.
From my understanding, the product version is only useful for server, proxy and controller.
I didn't really find use case for the product version for minions / clients.

What does this PR change?

  • Move product version declaration at base module level.
  • The product version is going to be added to grain template at the host module level and not at the individual module level.
  • Modify proxy and server to use the base configuration value if product version is not set at the individual module level.
  • Keep the possibility to overwrite the product version at individual module level.
  • Update cucumber testsuite module to impact those changes.

Note: individual modules are modules like modules/server/main.tf, modules/minion/main.tf, modules/proxy/main.tf where base module is modules/base/main.tf and host module is backend_modules/libvirt/host/main.tf

Other possibility

Declare the product version at the server level and use the the server_configuration to spread it to all other modules.
It will require more changes because the server_configuration variable is only declare in minion modules.

@maximenoel8 maximenoel8 self-assigned this Oct 2, 2024
@maximenoel8 maximenoel8 requested review from a team and meaksh October 2, 2024 00:33
Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's give it a try. Thanks!

@maximenoel8 maximenoel8 merged commit aed8598 into uyuni-project:master Oct 2, 2024
3 checks passed
@maximenoel8 maximenoel8 deleted the move_product_version_base branch October 2, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants