sonarcloud suggestions

java/code/src/com/redhat/rhn/taskomatic/TaskoXmlRpcInvoker.java

@@ -37,14 +37,13 @@
  */
 public class TaskoXmlRpcInvoker implements ProtocolHandler {
 
-    private static Logger log = LogManager.getLogger(TaskoXmlRpcInvoker.class);
-    private XmlRpcServer server;
+    private static final Logger LOG = LogManager.getLogger(TaskoXmlRpcInvoker.class);
+    private final XmlRpcServer server;
 
     /**
      * Constructor
      *
-     * @param xmlrpcServer
-     *            handles actual XML-RPC calls
+     * @param xmlrpcServer handles actual XML-RPC calls
      */
     public TaskoXmlRpcInvoker(XmlRpcServer xmlrpcServer) {
         server = xmlrpcServer;
@@ -58,10 +57,11 @@ public void handle(Request request, Response response) {
         String uri = request.getURI();
         InetAddress ip = request.getInetAddress();
 
-        try {
+        try (StringWriter writer = new StringWriter()) {
             if (!uri.startsWith("/RPC2")) {
                 String url = StringUtil.htmlifyText(uri);
 
+                LOG.info("Invalid request from {} to {}", ip, uri);
                 response.setCode(404);
                 response.setText(url);
                 PrintStream out = response.getPrintStream();
@@ -74,7 +74,6 @@ public void handle(Request request, Response response) {
             }
             else {
                 InputStream in = request.getInputStream();
-                StringWriter writer = new StringWriter();
                 server.execute(in, writer);
                 OutputStream out = response.getOutputStream();
                 response.set("Content-Type", "text/xml");
@@ -85,19 +84,15 @@ public void handle(Request request, Response response) {
             }
         }
         catch (IOException e) {
-            log.error("Error handling request", e);
+            LOG.error("Failed request by {}", ip, e);
         }
         finally {
             try {
                 response.commit();
             }
             catch (IOException e) {
-                log.error("Error sending response", e);
+                LOG.error("Error sending response", e);
             }
         }
-
-
-
     }
-
 }