Fixed unit test

uyuni-project · Oct 2, 2023 · c50f2bf · c50f2bf
1 parent b10214d
commit c50f2bf
Showing 1 changed file with 22 additions and 3 deletions.
diff --git a/java/code/src/com/redhat/rhn/taskomatic/task/payg/test/PaygUpdateAuthTaskTest.java b/java/code/src/com/redhat/rhn/taskomatic/task/payg/test/PaygUpdateAuthTaskTest.java
@@ -59,6 +59,7 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.quartz.JobExecutionException;
 
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
@@ -103,8 +104,6 @@ public void setUp() throws Exception {
         paygAuthDataExtractorMock = mock(PaygAuthDataExtractor.class);
         contentSyncManagerMock = mock(ContentSyncManager.class);
 
-        checking(new Expectations() {{ allowing(contentSyncManagerMock).updateRepositories(null); }});
-
         paygUpdateAuthTask = new PaygUpdateAuthTask();
 
         paygUpdateAuthTask.setCloudPaygManager(new CloudPaygManager());
@@ -141,6 +140,7 @@ private void clearDb() {
     public void testLocalhostPaygConnection() throws Exception {
         checking(new Expectations() {
             {
+                allowing(contentSyncManagerMock).updateRepositoriesPayg();
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
                 will(returnValue(paygInstanceInfo));
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
@@ -238,10 +238,13 @@ public boolean isPaygInstance() {
             }
         }
     }
+
+    @Test
     public void testRHUIConnection() throws Exception {
         PaygInstanceInfo rhuiInstanceInfo = createRHUIInstanceInfo();
         checking(new Expectations() {
             {
+                allowing(contentSyncManagerMock).updateRepositoriesPayg();
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
                 will(returnValue(rhuiInstanceInfo));
             }});
@@ -308,6 +311,7 @@ else if (cs.getLabel().equals("repo-label-2-c" + cid)) {
     public void testJschException() throws Exception {
         checking(new Expectations() {
             {
+                allowing(contentSyncManagerMock).updateRepositoriesPayg();
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
                 will(throwException(new JSchException("My JSchException exception")));
             }});
@@ -324,6 +328,7 @@ public void testJschException() throws Exception {
     public void testPaygDataExtractException() throws Exception {
         checking(new Expectations() {
             {
+                allowing(contentSyncManagerMock).updateRepositoriesPayg();
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
                 will(throwException(new PaygDataExtractException("My PaygDataExtractException")));
             }});
@@ -346,6 +351,7 @@ public void testPaygDataExtractException() throws Exception {
     public void testPaygDataExtractExceptionInvalidateCredentials() throws Exception {
         checking(new Expectations() {
             {
+                allowing(contentSyncManagerMock).updateRepositoriesPayg();
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
                 will(returnValue(paygInstanceInfo));
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
@@ -406,7 +412,7 @@ public void testPaygDataExtractExceptionInvalidateCredentials() throws Exception
     public void testGenericException() throws Exception {
         checking(new Expectations() {
             {
-
+                allowing(contentSyncManagerMock).updateRepositoriesPayg();
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
                 will(throwException(new Exception("My Exception")));
             }});
@@ -423,6 +429,7 @@ public void testGenericException() throws Exception {
     public void testSuccessClearStatus() throws Exception {
         checking(new Expectations() {
             {
+                allowing(contentSyncManagerMock).updateRepositoriesPayg();
                 oneOf(paygAuthDataExtractorMock).extractAuthData(with(any(PaygSshData.class)));
                 will(returnValue(paygInstanceInfo));
             }});
@@ -433,6 +440,18 @@ public void testSuccessClearStatus() throws Exception {
         assertEquals(0, UserNotificationFactory.listAllNotificationMessages().size());
     }
 
+    @Test
+    public void doNotCallContentSyncManagerIfNoSshDataConnectionIsDefined() throws JobExecutionException {
+        PaygSshDataFactory.lookupPaygSshData().forEach(PaygSshDataFactory::deletePaygSshData);
+        commitAndCloseSession();
+
+        checking(new Expectations() {{
+            never(contentSyncManagerMock).updateRepositoriesPayg();
+        }});
+
+        paygUpdateAuthTask.execute(null);
+    }
+
     private PaygSshData createPaygSshData() {
         PaygSshData paygSshData = PaygSshDataFactory.createPaygSshData();
         paygSshData.setDescription("My special instance");