Extract method to improve readability

uyuni-project · Jul 19, 2023 · f01e06f · f01e06f
1 parent 5752a99
commit f01e06f
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/java/code/src/com/redhat/rhn/taskomatic/task/repomd/RpmRepositoryWriter.java b/java/code/src/com/redhat/rhn/taskomatic/task/repomd/RpmRepositoryWriter.java
@@ -548,13 +548,7 @@ private RepomdIndexData loadRepoMetadataFile(Channel channel, String checksumAlg
 
         try (DigestInputStream digestStream = new DigestInputStream(stream, MessageDigest.getInstance(checksumAlgo))) {
 
-            try {
-                byte[] bytes = new byte[10];
-                while (digestStream.read(bytes) != -1) {
-                    // no-op, just consume the stream
-                }
-            }
-            catch (IOException e) {
+            if (!computeDigest(digestStream)) {
                 return null;
             }
 
@@ -571,6 +565,19 @@ private RepomdIndexData loadRepoMetadataFile(Channel channel, String checksumAlg
         }
     }
 
+    private static boolean computeDigest(DigestInputStream digestStream) {
+        try {
+            byte[] bytes = new byte[10];
+            while (digestStream.read(bytes) != -1) {
+                // no-op, just fully consume the stream so that the digest is computed
+            }
+        }
+        catch (IOException e) {
+            return false;
+        }
+        return true;
+    }
+
     /**
      * Generates update info for given channel
      * @param channel channel info