Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system highstate page layout #8731

Closed
Etheryte opened this issue May 15, 2024 · 1 comment · Fixed by #8933
Closed

Fix system highstate page layout #8731

Etheryte opened this issue May 15, 2024 · 1 comment · Fixed by #8933
Assignees

Comments

@Etheryte
Copy link
Member

Part of https://github.com/SUSE/spacewalk/issues/18940

All urls below are specified as the dev proxy (yarn proxy https://...), since that's the most convenient way to work on these issues.

To switch between the new theme and the old theme in the console: debugUtils.toggleUpdatedTheme()
To switch between the Suma theme and the Uyuni theme: debugUtils.toggleTheme()


See e.g. https://localhost:8080/rhn/manager/systems/details/highstate?sid=1000010006&

For this page, it's hard to say whether the old page or new page should be the baseline for fixing as they're both a bit broken.
I think it would be reasonable to just fix the page to a reasonably good state in the new theme, ignore the old theme part, and add the page to the updated page list.

Screenshot 2024-05-15 at 15 39 27 Screenshot 2024-05-15 at 15 39 33

Definition of done

The updated theme has no visual bugs, all related page urls are added to ViewHelper.java and view-helper.ts.

@bisht-richa
Copy link
Contributor

Fixed: #8933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants