Fix persisting the Cobbler UID in the database via XML-RPC createSystemRecord #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
API
java
java_lint_checkstyle
java_pgsql_tests
old-ui
xmlrpc
labels
Suggested tests to cover this Pull Request
|
14 tasks
SchoolGuy
force-pushed
the
fix/xml-rpc-createSystemRecord
branch
from
14e645d
to
56dd288
Compare
|
The PR is working as expected in a test environment. Thus I will now start writing Unit Tests with Mockito (as discussed internally). |
SchoolGuy
force-pushed
the
fix/xml-rpc-createSystemRecord
branch
2 times, most recently
from
63efc3b
to
b92a1e8
Compare
|
Git History is clean and Sonarlint should be happy about this PR. Tests need fixing as they are skeletons only at the moment. |
SchoolGuy
force-pushed
the
fix/xml-rpc-createSystemRecord
branch
from
b92a1e8
to
33b6522
Compare
SchoolGuy
force-pushed
the
fix/xml-rpc-createSystemRecord
branch
2 times, most recently
from
31c6484
to
c6b8bb7
Compare
|
The tests are missing atm. Other then that manual validation by me was successful. A Java squad member should try to finish the currently 6 failing tests. |
|
Any updates on this? |
|
@nodeg I'm currently working on getting this PR in shape so it can be merged. |
This commit addresses a regression that was introduced in 92e5a19. When the server object is not passed to CobblerSystemCreateCommand the Cobbler UID is not persisted in the database which leads to Cobbler rejecting the API requests that SUSE Manager does. This doesn't happen via the UI since it passes the server object via a different constructor than the XML-RPC API.
ycedres
force-pushed
the
fix/xml-rpc-createSystemRecord
branch
from
c6b8bb7
to
8355538
Compare
|
Thank you for the update, Yeray! |
Merged
12 tasks
|
Closing in favor of #7738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
TODO
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Cucumber tests were added - QE: Improve Cobbler tests and add a new profile test #6628
DONE
Links
Fixes #
Tracks # add downstream PR, if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: