-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set package refresh scheduler if possible #6969
Merged
parlt91
merged 3 commits into
uyuni-project:master
from
parlt91:set-package-refresh-scheduler
Aug 17, 2023
Merged
Set package refresh scheduler if possible #6969
parlt91
merged 3 commits into
uyuni-project:master
from
parlt91:set-package-refresh-scheduler
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlt91
changed the title
Set package refresh scheduler
Set package refresh scheduler if possible
May 2, 2023
Suggested tests to cover this Pull Request
|
parlt91
force-pushed
the
set-package-refresh-scheduler
branch
from
May 2, 2023 11:29
718f4ab
to
eb08d02
Compare
mcalmer
reviewed
May 2, 2023
java/code/src/com/suse/manager/reactor/messaging/JobReturnEventMessageAction.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/webui/services/SaltServerActionService.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/webui/services/SaltServerActionService.java
Outdated
Show resolved
Hide resolved
srbarrios
approved these changes
May 3, 2023
parlt91
force-pushed
the
set-package-refresh-scheduler
branch
3 times, most recently
from
May 3, 2023 09:03
563899f
to
ec921c1
Compare
mcalmer
approved these changes
May 3, 2023
parlt91
force-pushed
the
set-package-refresh-scheduler
branch
from
May 5, 2023 10:05
ec921c1
to
9805a8e
Compare
Signed-off-by: Pascal Arlt <parlt@suse.com>
Signed-off-by: Pascal Arlt <parlt@suse.com>
parlt91
force-pushed
the
set-package-refresh-scheduler
branch
from
August 16, 2023 08:56
9805a8e
to
8f4e635
Compare
cbbayburt
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember this from earlier 👍
Thanks for going through with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR was originally part of an L3 but it got closed due to noresponse. In the end I forgot to merge it. I think this change is a valuable addition though, so I think we should still merge it.
Change default/fallback scheduler from
(none)
to(system)
Set the scheduler on
package list refresh
action if possibleGUI diff
No difference.
Documentation
No documentation needed:
DONE
Test coverage
No tests: already covered (existing tests adapted)
DONE
Links
Tracks https://github.com/SUSE/spacewalk/issues/21290
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: