Suma payg part1 #7174
Merged
Suma payg part1 #7174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested tests to cover this Pull Request
|
|
Hi! Sorry there was an issue with podman. The issue is fixed in master. Could you please rebase your PR? Sorry for any inconvenience. |
Etheryte
reviewed
Jun 25, 2023
| @@ -46,6 +46,7 @@ const PaygInfoEdit = (props: Props) => { | |||
| setItem(props.payg); | |||
| setErrors(null); | |||
| }} | |||
| disableEditing={!props.editing} | |||
There was a problem hiding this comment.
Here and elsewhere where this name is used, I would recommend making the prop name consistent across the board. payg.renderer.tsx uses the name readOnly which seems to have the same purpose, I think that name is better.
There was a problem hiding this comment.
Fixed. Could please double check that I haven't missed any places where the property needs to be updated?
Etheryte
approved these changes
Jun 25, 2023
|
Something went wrong with the rebase |
|
I am removing @uyuni-project/release-engineering from this PR as reviewers. Please add us again only when the PR is ready to review, as we are getting a lot of notifications and it seems you still need to rebase. |
|
@mcalmer Hi! You need to rebase to be able to run the acceptance tests. They are failing now because of wrong podman version. Sorry for any inconvenience. |
change also storing of credentials while processing auth data
…om Cloud RMT Cloud RMT returns always empty results for subscriptions and repos. But we need to run refreshRepositories to correctly enable free products and repos
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
First part of SUMA PAYG feature.
Port of SUSE/spacewalk#21819
Obsolete #7173
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: