Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install products on openSUSE client OSes #7187

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

agraul
Copy link
Member

@agraul agraul commented Jun 22, 2023

What does this PR change?

openSUSE repos often contain multiple "product packages", that conflict. The idea is that installer installs the correct product once and that's it. In Uyuni, we currently install all products we can find. That does not work because of the conflict.

GUI diff

No difference.

Documentation

  • No documentation needed: only internal and user invisible changes

Test coverage

  • No tests: this came up when using openSUSE MicroOS. Until we test with client OSes where this happens (like MicroOS or Tumbleweed), we can't test this properly

Links

Fixes #7068

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@agraul agraul force-pushed the fix-install_products-microos branch from 73e54f6 to ca231fc Compare June 22, 2023 14:12
@agraul agraul requested review from mcalmer and meaksh July 7, 2023 13:09
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that openSUSE mess around so much, but as it is a free product we do not strictly require to have the products installed.
So if it helps, fine with me

openSUSE repos often contain multiple "product packages", that conflict.
The idea is that installer installs the correct product once and that's
it. In Uyuni, we currently install all products we can find. That does
not work because of the conflict.
@agraul agraul force-pushed the fix-install_products-microos branch from ca231fc to a8af979 Compare July 17, 2023 12:17
@agraul agraul merged commit fec45aa into uyuni-project:master Jul 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to upgrade packages for MicroOs installation
2 participants