Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup sudo config #7242

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Jul 5, 2023

What does this PR change?

Cleanup sudoers configuration.

  • dropped spacewalk-setup-sudoers: it was only cleanup some configs in /etc/sudoers directly. Since years we already use /etc/sudoers.d/ directory with a standalone file. This "cleanup" should be applied already to all existing Uyuni and SUSE Manager installations
  • additionally drop susemanager-upgrade.sh script. It also touches sudoers, but the rest of the functionality is not needed anymore. In the past it was dealing also with oracle DB which is dropped already. This script is not part of our docs, so I think it is obsolete.

Note: user "apache" is already removed from sudoers file.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/13763

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

it is not part of any docs anymore and was used to upgrade oracle to pg
@mcalmer mcalmer requested a review from mbussolotto July 5, 2023 16:25
@mcalmer mcalmer requested a review from a team July 5, 2023 16:25
Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcalmer
Copy link
Contributor Author

mcalmer commented Jul 7, 2023

failed susemanager_unittests not caused by this PR

@mcalmer mcalmer merged commit 98716e5 into uyuni-project:master Jul 7, 2023
4 checks passed
@mcalmer mcalmer deleted the cleanup-sudo-config branch July 7, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants