Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Debian 12 Bookworm #7255

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Add Debian 12 Bookworm #7255

merged 4 commits into from
Oct 6, 2023

Conversation

mayrstefan
Copy link
Contributor

@mayrstefan mayrstefan commented Jul 9, 2023 •
edited
Loading

What does this PR change?

This is some basic preparation to support Debian 12 Bookworm

GUI diff

No difference.

  • DONE

Documentation

  • Documentation issue was created: #2353.

  • DONE

Test coverage

  • Cucumber tests were added

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mayrstefan mayrstefan requested review from a team as code owners July 9, 2023 18:26
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023 •
edited
Loading

Suggested tests to cover this Pull Request
  • minssh_salt_install_package
  • min_deblike_monitoring
  • srv_power_management
  • min_salt_mgrcompat_state
  • proxy_cobbler_pxeboot
  • allcli_software_channels_dependencies
  • allcli_system_group
  • minkvm_guests
  • srv_rename_hostname
  • srv_docker_cve_audit
  • min_empty_system_profiles
  • srv_cobbler_profile
  • srv_restart
  • min_ansible_control_node
  • srv_reportdb
  • srv_power_management_redfish
  • min_retracted_patches
  • min_bootstrap_negative
  • srv_user_configuration_salt_states
  • min_activationkey
  • allcli_reboot
  • min_bootstrap_ssh_key
  • srv_manage_activationkey
  • min_rhlike_salt
  • min_salt_formulas_advanced
  • srv_manage_channels_page
  • min_deblike_salt_install_package
  • buildhost_docker_build_image
  • min_salt_migration
  • srv_custom_system_info
  • min_recurring_action
  • proxy_as_pod_basic_tests
  • minssh_bootstrap_api
  • srv_advanced_search
  • min_salt_minion_details
  • srv_cobbler_distro
  • min_salt_lock_packages
  • srv_scc_user_credentials
  • min_deblike_openscap_audit
  • min_rhlike_ssh
  • min_check_patches_install
  • min_virthost
  • srv_datepicker
  • srv_power_management_api
  • min_salt_openscap_audit
  • min_salt_install_with_staging
  • min_move_from_and_to_proxy
  • allcli_config_channel
  • min_project_lotus
  • min_salt_software_states
  • min_config_state_channel_subscriptions
  • min_timezone
  • min_bootstrap_api
  • min_bootstrap_reactivation
  • min_rhlike_monitoring
  • min_salt_user_states
  • srv_distro_cobbler
  • minssh_ansible_control_node
  • min_rhlike_salt_install_package_and_patch
  • min_config_state_channel_api
  • min_deblike_salt
  • buildhost_docker_auth_registry
  • buildhost_osimage_build_image
  • srv_monitoring
  • min_deblike_salt_install_with_staging
  • srv_group_union_intersection
  • min_cve_audit
  • min_rhlike_remote_command
  • allcli_action_chain
  • min_salt_pkgset_beacon
  • proxy_retail_pxeboot_and_mass_import
  • buildhost_bootstrap
  • proxy_branch_network
  • min_rhlike_openscap_audit
  • min_bootstrap_script
  • srv_virtual_host_manager
  • proxy_register_as_minion_with_script
  • min_cve_id_new_syntax
  • allcli_sanity
  • min_deblike_ssh
  • min_salt_install_package
  • min_config_state_channel
  • min_salt_minions_page
  • srv_menu
  • min_monitoring
  • min_change_software_channel
  • min_action_chain
  • min_deblike_remote_command
  • minssh_action_chain
  • sle_ssh_minion
  • min_salt_formulas
  • allcli_overview_systems_details
  • min_custom_pkg_download_endpoint
  • allcli_software_channels
  • srv_maintenance_windows
  • sle_minion
  • min_ssh_tunnel
  • minssh_move_from_and_to_proxy

This was referenced Jul 9, 2023
Closed
Merged
srbarrios
srbarrios reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test code LGTM.

@deneb-alpha deneb-alpha mentioned this pull request Jul 25, 2023
Closed
12 tasks
mcalmer
mcalmer requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this 1 TODO section (debian12-amd64) from mgr_bootstrap_data.py
The second change in that file (debian12-amd64-uyuni) should to stay

susemanager/src/mgr_bootstrap_data.py Outdated Show resolved Hide resolved
@mayrstefan mayrstefan requested review from a team as code owners September 8, 2023 18:09
@mayrstefan mayrstefan requested review from wweellddeerr and vzhestkov and removed request for a team September 8, 2023 18:09
@github-actions github-actions bot added the proxy label Sep 8, 2023
@mayrstefan
Copy link
Contributor Author

I messed up my git rebase. Hope this is good enough now

juliogonzalez
juliogonzalez approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I think the other reviewers should approve in case I am missing something on the testsuite or Java code.

@juliogonzalez
Copy link
Member

Reviewers: I asked for a review from you again, as neither our you approved. You left comments, or directly requested changes.

vzhestkov
vzhestkov approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me now. @mayrstefan thank you for taking care of it and for removing the change which was not related 👍

mackdk
mackdk approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@mackdk mackdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java part LGTM. The test failures are due to #7604 and are not related to this change itself

@mbussolotto mbussolotto mentioned this pull request Oct 4, 2023
Closed
12 tasks
mayrstefan and others added 4 commits October 4, 2023 17:52
@mayrstefan @mackdk
Add Debian 12 Bookworm
7ec0b8c
@srbarrios @mackdk
QE: Lazy initialization of Twopence nodes (#7334)
75661d2
@nodeg @mackdk
QE: Adapt BV code for Uyuni
124a6a8 
This will adjust the build validation test suite code for Uyuni.

Major differences compared to SUMA:

- Adding products via `spacewalk-common-channels`
- Different channel names
- no Liberty Linux 9 support

Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
@mayrstefan @juliogonzalez @mackdk
Add Debian 12 Backports to utils/spacewalk-common-channels.ini
a8042cd 
Co-authored-by: Julio González Gil <juliogonzalez@users.noreply.github.com>
@mackdk
Copy link
Contributor

mackdk commented Oct 4, 2023 •
edited
Loading

I rebased the branch on top of master and clean up the history a little bit. Acceptance tests should now be passing. @mcalmer could you please review again. Seems your requested change is still blocking the merge

@mackdk mackdk merged commit 9aaec81 into uyuni-project:master Oct 6, 2023
18 checks passed
@mayrstefan mayrstefan deleted the feature-add-debian-12 branch October 13, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcalmer mcalmer mcalmer approved these changes

@mackdk mackdk mackdk approved these changes

@juliogonzalez juliogonzalez juliogonzalez approved these changes

@vzhestkov vzhestkov vzhestkov approved these changes

@wweellddeerr wweellddeerr Awaiting requested review from wweellddeerr wweellddeerr was automatically assigned from uyuni-project/frontend

@srbarrios srbarrios Awaiting requested review from srbarrios

Assignees
No one assigned
Labels
build-validation-features ci-pipelines community data-model java_lint_checkstyle java_pgsql_tests java needs-translation python3 ruby_rubocop susemanager_unittests test-framework testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mayrstefan @juliogonzalez @mackdk @mcalmer @srbarrios @vzhestkov @cbbayburt @nodeg