Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonarcloud reported bugs in new code #7264

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Jul 14, 2023

What does this PR change?

Fix 3 sonarcloud issues in new code

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Suggested tests to cover this Pull Request
  • srv_handle_software_channels_with_ISS_v2
  • srv_create_activationkey
  • srv_menu
  • srv_power_management_redfish
  • srv_notifications
  • srv_payg_ssh_connection
  • min_change_software_channel
  • srv_distro_cobbler
  • allcli_reboot
  • min_timezone
  • minssh_action_chain
  • min_rhlike_remote_command
  • allcli_overview_systems_details
  • srv_delete_channel_with_tool
  • min_rhlike_openscap_audit
  • srv_docker
  • allcli_action_chain
  • srv_check_reposync
  • min_deblike_salt_install_package
  • srv_clone_channel_npn
  • srv_reportdb
  • buildhost_docker_build_image
  • min_config_state_channel_subscriptions
  • proxy_register_as_minion_with_script
  • min_bootstrap_ssh_key
  • srv_restart
  • allcli_software_channels
  • min_salt_minions_page
  • min_salt_mgrcompat_state
  • srv_create_repository
  • srv_advanced_search
  • srv_patches_page
  • min_deblike_remote_command
  • minssh_ansible_control_node
  • srv_disable_local_repos_off
  • srv_channel_api
  • srv_change_password
  • proxy_retail_pxeboot_and_mass_import
  • srv_osimage
  • srv_push_package
  • srv_power_management
  • srv_docker_cve_audit
  • srv_dist_channel_mapping
  • srv_datepicker
  • min_salt_formulas_advanced
  • srv_change_task_schedule
  • srv_first_settings
  • srv_custom_system_info
  • min_bootstrap_negative
  • minssh_bootstrap_api
  • srv_task_status_engine
  • srv_activationkey_api
  • min_empty_system_profiles
  • srv_logfile
  • min_salt_pkgset_beacon
  • srv_salt
  • srv_maintenance_windows
  • srv_users
  • min_cve_audit
  • min_salt_formulas
  • min_deblike_ssh
  • min_ssh_tunnel
  • minssh_salt_install_package
  • srv_user_preferences
  • min_monitoring
  • srv_handle_config_channels_with_ISS_v2
  • srv_power_management_api
  • min_action_chain
  • srv_delete_channel_from_ui
  • min_deblike_salt
  • srv_content_lifecycle
  • min_salt_minion_details
  • min_bootstrap_script
  • sle_ssh_minion
  • sle_minion
  • srv_check_sync_source_packages
  • min_cve_id_new_syntax
  • srv_check_channels_page
  • min_move_from_and_to_proxy
  • srv_monitoring
  • min_rhlike_monitoring
  • srv_group_union_intersection
  • srv_scc_user_credentials
  • min_bootstrap_reactivation
  • srv_cobbler_profile
  • min_salt_install_package
  • min_check_patches_install
  • min_rhlike_salt
  • srv_salt_download_endpoint
  • srv_add_rocky8_repositories
  • min_bootstrap_api
  • min_rhlike_ssh
  • min_salt_openscap_audit
  • min_deblike_openscap_audit
  • min_recurring_action
  • min_deblike_salt_install_with_staging
  • min_rhlike_salt_install_package_and_patch
  • min_project_lotus
  • srv_channels_add
  • minkvm_guests
  • min_activationkey
  • srv_enable_sync_products
  • srv_cobbler_distro
  • proxy_as_pod_basic_tests
  • srv_sync_channels
  • min_deblike_monitoring
  • min_salt_user_states
  • allcli_update_activationkeys
  • proxy_branch_network
  • minssh_move_from_and_to_proxy
  • buildhost_bootstrap
  • srv_user_configuration_salt_states
  • srv_rename_hostname
  • allcli_config_channel
  • min_salt_lock_packages
  • min_salt_install_with_staging
  • min_virthost
  • srv_organization_credentials
  • srv_cobbler_buildiso
  • srv_cobbler_sync
  • min_ansible_control_node
  • srv_docker_advanced_content_management
  • srv_mainpage
  • min_config_state_channel
  • allcli_system_group
  • min_retracted_patches
  • min_docker_api
  • buildhost_osimage_build_image
  • srv_manage_channels_page
  • min_salt_software_states

@cbosdo cbosdo merged commit 52ae76a into uyuni-project:master Jul 16, 2023
12 of 13 checks passed
@cbosdo cbosdo deleted the sonar-fixes branch July 16, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant