Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr-ssl-cert-setup: Store ca in db #7267

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Jul 15, 2023

What does this PR change?

Use mgr-ssl-cert-setup to store a new CA certificate in the database.
Drop this single task from spacewalk-setup.

GUI diff

No difference.

  • DONE

Documentation

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/21991
Tracks https://github.com/SUSE/spacewalk/pull/22020

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@cbosdo
Copy link
Contributor

cbosdo commented Jul 16, 2023

@mcalmer I will need to have a chat with you on this one before you merge it: this could become a real pain for kubernetes

Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a card to remove the need of that CA in the DB for later

@mcalmer
Copy link
Contributor Author

mcalmer commented Jul 18, 2023

The failed test is not caused by this PR

@mcalmer mcalmer merged commit 4b6022c into uyuni-project:master Jul 18, 2023
7 checks passed
@mcalmer mcalmer deleted the store-ca-in-db branch July 18, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants