-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Debian 12 repositories to spacewalk-common-channels.ini #7269
Conversation
hello @stdevel it should be added directly to the .changes file, not only in the description of the PR. For adding the changes to the right file, you can follow this documentation: https://github.com/uyuni-project/uyuni/wiki/Contributing#changelog-rules-for-packages-in-git And, if you need help, do not hesitate to ask and I'll guide you more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @stdevel and thanks for this PR.
could you please add the missing changelog entry too?
see also: #7269 (comment)
Thanks for pointing out - just added the missing changelog entry. Hope this helps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your support here!
I just noticed that for Debian 12 there's another contributor working at the needed enhancements (#7255).
Let me check with the team which is the best approach to follow.
I would be fine with this. Did a dedicated PR because I didn't know whether the Uyuni developers would be fine with addind the backports repository at all. :) |
So after some discussion it seems our uyuni client tools repos for debian 12 are not ready yet so we will have to wait for those before merging any debian 12 support. That means it would make more sense if we keep the other backports PR for 10/11 so we can merge it earlier and leave 12 backports in this PR but removing the duplication to #7255. So this PR here would be just adding debian 12 backports and we will merge it right after #7255. Does that sound good? |
Hi @lucidd, |
HI Can you update the file /usr/share/susemanager/mgr_bootstrap_data.py to create the debian12 bootstrap repo please ? |
Looks like this has already been changed here: https://github.com/uyuni-project/uyuni/pull/7255/files#diff-f55fddc0bdf6c50cd2d8405836ce20fc7167a07bb22b5828b9f973b063d2a83f Maybe @deneb-alpha knows how these two PRs will be handled together. |
HI Christian,
ok thank you I will take a look.
Best regards.
…On Tue, Sep 26, 2023 at 7:24 AM Christian Stankowic < ***@***.***> wrote:
HI Can you update the file /usr/share/susemanager/mgr_bootstrap_data.py to
create the debian12 bootstrap repo please ?
Looks like this has already been changed here:
https://github.com/uyuni-project/uyuni/pull/7255/files#diff-f55fddc0bdf6c50cd2d8405836ce20fc7167a07bb22b5828b9f973b063d2a83f
Maybe @deneb-alpha <https://github.com/deneb-alpha> knows how these two
PRs will be handled together.
—
Reply to this email directly, view it on GitHub
<#7269 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASWWRPAP2RL424BWLWGKSNLX4JRJLANCNFSM6AAAAAA2L6RT74>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Reynald CHEKHINA
*SA, Square1*
*e: ***@***.*** ***@***.***>*
Company Registration Number: 528714
VAT number IE3178050PH
|
@stdevel hello :) |
I close this now. Everything should be implemented |
What does this PR change?
Currently, spacewalk-common-channels.ini shipped with Uyuni lacks the repositories for Debian 12. I assume this might be planned for Uyuni 2023.06 or 2023.07.
This PR adds the missing repositories as well as the backports (see also related PR #6912)
GUI diff
No difference.
Before:
After:
Documentation
No documentation needed: it only adds additional repositories to an optional CLI tool
DONE
Test coverage
No tests:
spacewalk-common-channels
is an optional CLI utility and not a crucial part of UyuniDONE
Links
Fixes #7268
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: