Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Debian 12 repositories to spacewalk-common-channels.ini #7269

Closed
wants to merge 3 commits into from

Conversation

stdevel
Copy link
Contributor

@stdevel stdevel commented Jul 16, 2023

What does this PR change?

Currently, spacewalk-common-channels.ini shipped with Uyuni lacks the repositories for Debian 12. I assume this might be planned for Uyuni 2023.06 or 2023.07.

This PR adds the missing repositories as well as the backports (see also related PR #6912)

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

  • No documentation needed: it only adds additional repositories to an optional CLI tool

  • DONE

Test coverage

  • No tests: spacewalk-common-channels is an optional CLI utility and not a crucial part of Uyuni

  • DONE

Links

Fixes #7268

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

- add missing Debian 12 repositories (including backports) for spacewalk-common-channels

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@deneb-alpha
Copy link
Contributor

hello @stdevel
do you need any help for adding the changelog entry?

it should be added directly to the .changes file, not only in the description of the PR.
For instance, the file that will get the entry with your changes is https://github.com/uyuni-project/uyuni/blob/master/utils/spacewalk-utils.changes

For adding the changes to the right file, you can follow this documentation: https://github.com/uyuni-project/uyuni/wiki/Contributing#changelog-rules-for-packages-in-git

And, if you need help, do not hesitate to ask and I'll guide you more

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @stdevel and thanks for this PR.
could you please add the missing changelog entry too?
see also: #7269 (comment)

@stdevel
Copy link
Contributor Author

stdevel commented Jul 24, 2023

hello @stdevel and thanks for this PR. could you please add the missing changelog entry too? see also: #7269 (comment)

Thanks for pointing out - just added the missing changelog entry. Hope this helps!

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your support here!

I just noticed that for Debian 12 there's another contributor working at the needed enhancements (#7255).

Let me check with the team which is the best approach to follow.

@deneb-alpha deneb-alpha self-requested a review July 25, 2023 08:10
@lucidd
Copy link
Member

lucidd commented Jul 26, 2023

If i see this correctly the only difference to #7255 is the addition of debian-12-amd64-main-backports-uyuni. My suggestion would be to close this PR and move debian 12 backports to your other PR (#6912). What do you think?

@stdevel
Copy link
Contributor Author

stdevel commented Jul 26, 2023

If i see this correctly the only difference to #7255 is the addition of debian-12-amd64-main-backports-uyuni. My suggestion would be to close this PR and move debian 12 backports to your other PR (#6912). What do you think?

I would be fine with this. Did a dedicated PR because I didn't know whether the Uyuni developers would be fine with addind the backports repository at all. :)

@lucidd
Copy link
Member

lucidd commented Jul 27, 2023

So after some discussion it seems our uyuni client tools repos for debian 12 are not ready yet so we will have to wait for those before merging any debian 12 support. That means it would make more sense if we keep the other backports PR for 10/11 so we can merge it earlier and leave 12 backports in this PR but removing the duplication to #7255. So this PR here would be just adding debian 12 backports and we will merge it right after #7255. Does that sound good?

@stdevel
Copy link
Contributor Author

stdevel commented Aug 12, 2023

Hi @lucidd,
that sounds fine - sorry for the late answer, I've been on vacation. :)

@rchekhina
Copy link

HI Can you update the file /usr/share/susemanager/mgr_bootstrap_data.py to create the debian12 bootstrap repo please ?

@stdevel
Copy link
Contributor Author

stdevel commented Sep 26, 2023

HI Can you update the file /usr/share/susemanager/mgr_bootstrap_data.py to create the debian12 bootstrap repo please ?

Looks like this has already been changed here: https://github.com/uyuni-project/uyuni/pull/7255/files#diff-f55fddc0bdf6c50cd2d8405836ce20fc7167a07bb22b5828b9f973b063d2a83f

Maybe @deneb-alpha knows how these two PRs will be handled together.

@rchekhina
Copy link

rchekhina commented Sep 26, 2023 via email

@deneb-alpha
Copy link
Contributor

@stdevel hello :)
All the changes should be already in master now. I think we can close this PR now.

@mcalmer
Copy link
Contributor

mcalmer commented Oct 23, 2023

I close this now. Everything should be implemented

@mcalmer mcalmer closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian 12 repositories missing in spacewalk-common-channels
6 participants