Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse virtual-host-gatherer null value #7282

Merged

Conversation

mbussolotto
Copy link
Member

@mbussolotto mbussolotto commented Jul 18, 2023

What does this PR change?

parse virtual-host-gatherer null value.
Fix for Virtual host manager web UI cucumber tests

GUI diff

Before:

Screenshot from 2023-07-18 15-08-58

Screenshot from 2023-07-18 15-10-12

  • DONE

Documentation

  • No documentation needed
  • DONE

Test coverage

  • Unit tests were added

  • DONE

Links

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mbussolotto mbussolotto changed the base branch from master to server-container July 18, 2023 12:57
@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • srv_virtual_host_manager
  • buildhost_docker_auth_registry
  • srv_menu
  • buildhost_docker_build_image
  • buildhost_osimage_build_image

@mbussolotto mbussolotto changed the title Server container parse virtual-host-gatherer null value Jul 18, 2023
@mbussolotto mbussolotto marked this pull request as ready for review July 18, 2023 13:00
@mbussolotto mbussolotto requested a review from a team as a code owner July 18, 2023 13:00
@mbussolotto mbussolotto requested review from lucidd and removed request for a team July 18, 2023 13:00
@mbussolotto mbussolotto requested a review from cbosdo July 18, 2023 13:01
@mbussolotto
Copy link
Member Author

mbussolotto commented Jul 18, 2023

@cbosdo it seems that 5a6ca6c is not enough to parse null value. I also added unit test. Let me know what you think about it ;)

@mbussolotto mbussolotto removed the request for review from lucidd July 18, 2023 13:06
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbussolotto mbussolotto merged commit f125821 into uyuni-project:server-container Jul 18, 2023
5 of 11 checks passed
mbussolotto added a commit to mbussolotto/uyuni that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants