-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse virtual-host-gatherer null value #7282
Merged
mbussolotto
merged 2 commits into
uyuni-project:server-container
from
mbussolotto:server-container
Jul 18, 2023
Merged
parse virtual-host-gatherer null value #7282
mbussolotto
merged 2 commits into
uyuni-project:server-container
from
mbussolotto:server-container
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested tests to cover this Pull Request
|
cbosdo
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mbussolotto
merged commit Jul 18, 2023
f125821
into
uyuni-project:server-container
5 of 11 checks passed
mbussolotto
added a commit
to mbussolotto/uyuni
that referenced
this pull request
Aug 3, 2023
mbussolotto
added a commit
that referenced
this pull request
Aug 4, 2023
nodeg
pushed a commit
to nodeg/uyuni
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
parse virtual-host-gatherer null value.
Fix for
Virtual host manager web UI
cucumber testsGUI diff
Before:
Documentation
Test coverage
Unit tests were added
DONE
Links
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: