Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy container config is created on server where CA should not be added to DB #7289

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Jul 19, 2023

What does this PR change?

Do not try to deploy the proxy CA for containerized proxy into DB.
This code is executed on the Server and not on the proxy.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

See https://github.com/SUSE/spacewalk/issues/22046
Additional fix for #7267
Tracks https://github.com/SUSE/spacewalk/pull/22048

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mcalmer mcalmer requested a review from a team as a code owner July 19, 2023 12:49
@mcalmer mcalmer requested review from meaksh and cbosdo and removed request for a team July 19, 2023 12:49
@mcalmer mcalmer merged commit a877fc1 into uyuni-project:master Jul 19, 2023
8 of 9 checks passed
@mcalmer mcalmer deleted the fix-container-ssl-setup branch July 19, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants