Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance new systems list filter UI #7317

Merged

Conversation

wweellddeerr
Copy link
Contributor

@wweellddeerr wweellddeerr commented Jul 26, 2023

What does this PR change?

It introduces the SelectSearchField component, seamlessly integrated with the Table component, to enhance the filtering capabilities of the new systems list. Now, instead of always being a simple text field, some filters are shown as select list (when it is possible).

GUI diff

Before:
image

After:

image

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/19409

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@wweellddeerr wweellddeerr marked this pull request as ready for review July 27, 2023 12:29
@wweellddeerr wweellddeerr requested a review from a team as a code owner July 27, 2023 12:29
@wweellddeerr wweellddeerr requested review from Etheryte and removed request for a team July 27, 2023 12:29
Copy link
Member

@Etheryte Etheryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good and clean, thanks a lot for implementing this. 👍

Only one tangential question, could this be used to make recurring-actions-search-target-type-filter.tsx and recurring-actions-search-action-type-filter.tsx obsolete? The code looks fairly similar.

@wweellddeerr
Copy link
Contributor Author

This looks really good and clean, thanks a lot for implementing this. +1

Only one tangential question, could this be used to make recurring-actions-search-target-type-filter.tsx and recurring-actions-search-action-type-filter.tsx obsolete? The code looks fairly similar.

Thank you!

Yes, your observation is correct, the idea is to refactor the recurring action components right after.

@wweellddeerr wweellddeerr merged commit 099708e into uyuni-project:master Jul 28, 2023
16 of 20 checks passed
@cbosdo
Copy link
Contributor

cbosdo commented Jul 31, 2023

Should we somehow give some hints on the possible values for numerical fields? With numerical fields you can use operators in the value like ==, <=, <, >, >=, <> or !=. See https://github.com/uyuni-project/uyuni/blob/master/java/code/src/com/suse/manager/utils/PagedSqlQueryBuilder.java#L244 for the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants