Refactor: reuse table filter component in recurring actions feature #7328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wweellddeerr
force-pushed
the
refactor-recurring-actions-select-component
branch
from
ec90e0d
to
633ef80
Compare
Etheryte
reviewed
Jul 31, 2023
| import { SelectSearchField } from "components/table/SelectSearchField"; | ||
|
|
||
| const renderSearchField = (props) => { | ||
| const { field } = props; |
There was a problem hiding this comment.
This works, but feels a bit weird. I think it would make sense to either destruct everything (const { field, criteria, placeholder, onSearch, name } = props), or destruct nothing and use props.field in the line below this one. I think the latter makes more sense, but either way is fine with me as long as it's consistent.
Etheryte
reviewed
Jul 31, 2023
|
|
||
| export const TableFilter = (props) => { | ||
| // Dummy model and onChange to reuse the Select component as it requires a Form | ||
| let model = {}; |
There was a problem hiding this comment.
If this doesn't change it can be const.
Etheryte
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
It extracts common table filter code to a separate component (
TableFilter.tsx) and reuses it in systems list and recurring action features.GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Links
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: