-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove client_config_update #7340
remove client_config_update #7340
Conversation
9d20a73
to
a480723
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is strill referenced in rhn_bootstrap_strings.py
I saw there was lots a reference in traditional stack, but I don't see them now (this is the commit that removed reference mbussolotto@c1a347a ). What am I missing? |
Ahh, I looked into a 4.3 branch. Sorry :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can give it a try
21d29dc
to
fa4e8b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try to this refactor. Thanks! :)
BTW: I missed a proper description and motivation for this change on this PR description. This PR is not mentioning or linking to any other card where I can gather more context about this change. I only see "server-container-porting" label. Having a better description would definetely help on the review process.
What does this PR change?
In Uyuni container, we are going to persist
/srv/www/htdocs/pub
. The persisted folder should not contains any files owned by the image, since they would not be updated. Most of the files were moved with this PR #7407 , but sinceclient_config_update.py
is not used, we can get rid of it.GUI diff
No difference.
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE
Test coverage
Links
Partial Fixes https://github.com/SUSE/spacewalk/issues/22104
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: