Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove client_config_update #7340

Merged

Conversation

mbussolotto
Copy link
Member

@mbussolotto mbussolotto commented Aug 2, 2023

What does this PR change?

In Uyuni container, we are going to persist /srv/www/htdocs/pub . The persisted folder should not contains any files owned by the image, since they would not be updated. Most of the files were moved with this PR #7407 , but since client_config_update.py is not used, we can get rid of it.

GUI diff

No difference.

  • DONE

Documentation

Test coverage

  • No tests
  • DONE

Links

Partial Fixes https://github.com/SUSE/spacewalk/issues/22104

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is strill referenced in rhn_bootstrap_strings.py

@mbussolotto
Copy link
Member Author

it is strill referenced in rhn_bootstrap_strings.py

I saw there was lots a reference in traditional stack, but I don't see them now (this is the commit that removed reference mbussolotto@c1a347a ). What am I missing?

@mcalmer
Copy link
Contributor

mcalmer commented Aug 2, 2023

it is strill referenced in rhn_bootstrap_strings.py

I saw there was lots a reference in traditional stack, but I don't see them now (this is the commit that removed reference mbussolotto@c1a347a ). What am I missing?

Ahh, I looked into a 4.3 branch. Sorry :-)

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can give it a try

@mbussolotto mbussolotto marked this pull request as ready for review August 22, 2023 06:53
@mbussolotto mbussolotto requested a review from a team as a code owner August 22, 2023 06:53
@mbussolotto mbussolotto requested review from meaksh and removed request for a team August 22, 2023 06:53
Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try to this refactor. Thanks! :)

BTW: I missed a proper description and motivation for this change on this PR description. This PR is not mentioning or linking to any other card where I can gather more context about this change. I only see "server-container-porting" label. Having a better description would definetely help on the review process.

@mbussolotto mbussolotto merged commit e0b17ab into uyuni-project:master Sep 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants