Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend success message after enabling monitoring #7348

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

witekest
Copy link
Contributor

@witekest witekest commented Aug 2, 2023

What does this PR change?

The message hinting the user to open the required ports and pointing to the documentation was added.

GUI diff

Before:
image

After:
not tested

  • DONE

Documentation

  • No documentation needed: provides helpful information in the UI.

  • DONE

Test coverage

  • No tests: minor change

  • DONE

Links

Fixes #21944

  • DONE

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

The message hinting the user to open the required ports and pointing to
the documentation was added.

Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Suggested tests to cover this Pull Request
  • min_virthost
  • buildhost_bootstrap
  • srv_maintenance_windows
  • srv_reportdb
  • minssh_ansible_control_node
  • min_ansible_control_node
  • srv_advanced_search
  • srv_handle_software_channels_with_ISS_v2
  • srv_create_activationkey
  • srv_sync_products
  • srv_menu
  • srv_power_management_redfish
  • srv_notifications
  • allcli_software_channels_dependencies
  • srv_payg_ssh_connection
  • min_change_software_channel
  • srv_distro_cobbler
  • allcli_reboot
  • min_timezone
  • minssh_action_chain
  • min_rhlike_remote_command
  • allcli_overview_systems_details
  • srv_delete_channel_with_tool
  • min_rhlike_openscap_audit
  • srv_docker
  • allcli_action_chain
  • srv_check_reposync
  • min_deblike_salt_install_package
  • srv_clone_channel_npn
  • buildhost_docker_build_image
  • min_config_state_channel_subscriptions
  • proxy_register_as_minion_with_script
  • min_bootstrap_ssh_key
  • srv_restart
  • allcli_software_channels
  • min_salt_minions_page
  • min_salt_mgrcompat_state
  • srv_create_repository
  • srv_patches_page
  • min_deblike_remote_command
  • srv_disable_local_repos_off
  • srv_channel_api
  • srv_change_password
  • proxy_retail_pxeboot_and_mass_import
  • srv_osimage
  • buildhost_docker_auth_registry
  • srv_push_package
  • srv_power_management
  • srv_docker_cve_audit
  • srv_dist_channel_mapping
  • srv_datepicker
  • min_salt_formulas_advanced
  • srv_change_task_schedule
  • srv_first_settings
  • srv_custom_system_info
  • min_bootstrap_negative
  • minssh_bootstrap_api
  • srv_task_status_engine
  • srv_activationkey_api
  • min_empty_system_profiles
  • srv_logfile
  • min_salt_pkgset_beacon
  • srv_salt
  • srv_virtual_host_manager
  • srv_users
  • min_cve_audit
  • min_salt_formulas
  • min_deblike_ssh
  • min_ssh_tunnel
  • min_salt_migration
  • minssh_salt_install_package
  • srv_wait_for_reposync
  • srv_user_preferences
  • min_monitoring
  • srv_handle_config_channels_with_ISS_v2
  • srv_power_management_api
  • min_action_chain
  • srv_delete_channel_from_ui
  • min_deblike_salt
  • srv_content_lifecycle
  • min_salt_minion_details
  • min_bootstrap_script
  • sle_ssh_minion
  • sle_minion
  • srv_check_sync_source_packages
  • min_cve_id_new_syntax
  • srv_check_channels_page
  • min_move_from_and_to_proxy
  • srv_monitoring
  • min_rhlike_monitoring
  • srv_group_union_intersection
  • srv_scc_user_credentials
  • min_bootstrap_reactivation
  • srv_cobbler_profile
  • min_salt_install_package
  • min_check_patches_install
  • proxy_cobbler_pxeboot
  • min_rhlike_salt
  • srv_salt_download_endpoint
  • allcli_sanity
  • srv_add_rocky8_repositories
  • min_bootstrap_api
  • min_rhlike_ssh
  • min_salt_openscap_audit
  • min_deblike_openscap_audit
  • min_recurring_action
  • min_deblike_salt_install_with_staging
  • min_rhlike_salt_install_package_and_patch
  • min_project_lotus
  • srv_channels_add
  • srv_manage_activationkey
  • minkvm_guests
  • min_activationkey
  • srv_enable_sync_products
  • srv_cobbler_distro
  • proxy_as_pod_basic_tests
  • srv_sync_channels
  • min_deblike_monitoring
  • min_salt_user_states
  • allcli_update_activationkeys
  • proxy_branch_network
  • minssh_move_from_and_to_proxy
  • srv_user_configuration_salt_states
  • srv_rename_hostname
  • allcli_config_channel
  • min_salt_lock_packages
  • min_salt_install_with_staging
  • srv_organization_credentials
  • srv_cobbler_buildiso
  • srv_cobbler_sync
  • srv_docker_advanced_content_management
  • srv_mainpage
  • min_config_state_channel
  • allcli_system_group
  • min_retracted_patches
  • min_docker_api
  • buildhost_osimage_build_image
  • srv_manage_channels_page
  • min_custom_pkg_download_endpoint
  • min_salt_software_states

@@ -1,3 +1,4 @@
- Extend success message after adding monitoring property (bsc#1212168)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use mkchlog

Copy link
Contributor

@parlt91 parlt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what MC mentioned it looks good to me

Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
@witekest witekest requested a review from mcalmer August 4, 2023 13:23
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems there is a checkstyle error need fixing

Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
@witekest witekest requested a review from mcalmer August 4, 2023 13:54
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@witekest witekest merged commit 343c8bf into uyuni-project:master Aug 7, 2023
9 of 14 checks passed
@witekest witekest deleted the update_monitoring_added branch August 7, 2023 09:34
witekest added a commit to witekest/uyuni that referenced this pull request Aug 10, 2023
Actually used string resource is
system.entitle.added.monitoring_entitled.nodoc

Follow up of uyuni-project#7348

Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
@witekest witekest mentioned this pull request Aug 10, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants