-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend success message after enabling monitoring #7348
Extend success message after enabling monitoring #7348
Conversation
The message hinting the user to open the required ports and pointing to the documentation was added. Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
Suggested tests to cover this Pull Request
|
java/spacewalk-java.changes
Outdated
@@ -1,3 +1,4 @@ | |||
- Extend success message after adding monitoring property (bsc#1212168) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use mkchlog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than what MC mentioned it looks good to me
Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems there is a checkstyle error need fixing
Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Actually used string resource is system.entitle.added.monitoring_entitled.nodoc Follow up of uyuni-project#7348 Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
What does this PR change?
The message hinting the user to open the required ports and pointing to the documentation was added.
GUI diff
Before:
After:
not tested
Documentation
No documentation needed: provides helpful information in the UI.
DONE
Test coverage
No tests: minor change
DONE
Links
Fixes #21944
Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: