Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move /srv/www/htdoc/pub/repositories to /usr/share/susemanager/gpg/repositories #7407

Closed
wants to merge 1 commit into from

Conversation

mbussolotto
Copy link
Member

@mbussolotto mbussolotto commented Aug 11, 2023

What does this PR change?

Required by uyuni container, to avoid upgrade issue since /srv/www/htdoc/pub/repositories is persisted

move /srv/www/htdoc/pub/repositories to /usr/share/susemanager/gpg/repositories

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

Test coverage

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mbussolotto mbussolotto changed the title move /srv/www/htdoc/pub/repositories to /usr/share/susemanager/gpg/repositories missing folder move /srv/www/htdoc/pub/repositories to /usr/share/susemanager/gpg/repositories Aug 11, 2023
@aaannz
Copy link
Contributor

aaannz commented Sep 11, 2023

So if I understand this right, we need just empty repos there. The rest of repos will still be on the old location which in case of container will be a persistent volume, so the path /srv/www/htdoc/pub/repositories will be created by other means in the container.

But how about non containerized scenario? What package will create that path?

Does this work in an update scenario? Fortunately I think rpm will not remove those parent directories, because there will be files not owned by the package. Not sure scenario when update is done on unconfigured system, then rpm may very well remove /srv/www/htdoc/pub/repositories and we are back on my first question.

@mbussolotto
Copy link
Member Author

@aaannz, right. Probably the package should create the /srv/www/htdocs/pub/repositories (although empty), just to avoid issue on using and update it.
Anyway, I'll put the PR in draft, we realized that might be better to move everything is owned by the package away from /srv/www/. I'll update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants