Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE: Fix server restart via SSH #7417

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Aug 15, 2023

add description

This fixes some of the 4.3 CI issues found by @mcalmer which are leftovers from the Twopence lazy init backport. See https://github.com/SUSE/spacewalk/pull/22269

Twopence uses the following init, so the hostname rename and SSH reboot tests could be a bit simplified because we know what the server target is already and do not have to use its IP address:

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Cucumber tests were added

  • DONE

Links

Port of https://github.com/SUSE/spacewalk/pull/22313

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@nodeg
Copy link
Member Author

nodeg commented Aug 15, 2023

I have no idea why RuboCop suddenly complains about code I did not touch in this PR.

Run cd testsuite
Inspecting 40 files
....................C...................

Offenses:

features/support/constants.rb:201:[10](https://github.com/uyuni-project/uyuni/actions/runs/5866356247/job/15905013667?pr=7417#step:5:11): C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
  if ENV["PROVIDER"].include? 'podman'
         ^^^^^^^^^^

40 files inspected, 1 offense detected
Error: Process completed with exit code 1.

Nevertheless, I fixed it with an additional commit.

Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches.

See documentation nitpicks.

testsuite/documentation/cucumber-steps.md Outdated Show resolved Hide resolved
testsuite/documentation/cucumber-steps.md Outdated Show resolved Hide resolved
We do not have a `minion` step hostname any more.
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@nodeg
Copy link
Member Author

nodeg commented Aug 15, 2023

The one failing test is a flaky one.
image

@nodeg nodeg merged commit ada05c7 into uyuni-project:master Aug 15, 2023
9 of 10 checks passed
@nodeg nodeg deleted the qe-fixup-twopence branch August 15, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants