-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QE: Fix server restart via SSH #7417
Conversation
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
I have no idea why RuboCop suddenly complains about code I did not touch in this PR. Run cd testsuite
Inspecting 40 files
....................C...................
Offenses:
features/support/constants.rb:201:[10](https://github.com/uyuni-project/uyuni/actions/runs/5866356247/job/15905013667?pr=7417#step:5:11): C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
if ENV["PROVIDER"].include? 'podman'
^^^^^^^^^^
40 files inspected, 1 offense detected
Error: Process completed with exit code 1. Nevertheless, I fixed it with an additional commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catches.
See documentation nitpicks.
We do not have a `minion` step hostname any more.
ffeb241
to
b582401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
add description
This fixes some of the 4.3 CI issues found by @mcalmer which are leftovers from the Twopence lazy init backport. See https://github.com/SUSE/spacewalk/pull/22269
Twopence uses the following init, so the hostname rename and SSH reboot tests could be a bit simplified because we know what the server target is already and do not have to use its IP address:
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Cucumber tests were added
DONE
Links
Port of https://github.com/SUSE/spacewalk/pull/22313
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: