Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for localhost in correct table #7445

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Aug 21, 2023

What does this PR change?

Product Refresh is not working as we check for localhost connection in the wrong table

Test coverage

  • Unit tests were added

  • DONE

Links

Port of https://github.com/SUSE/spacewalk/pull/22365

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mcalmer mcalmer requested a review from a team as a code owner August 21, 2023 18:37
@mcalmer mcalmer requested review from wweellddeerr and removed request for a team August 21, 2023 18:37
@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • srv_handle_software_channels_with_ISS_v2
  • srv_manage_channels_page
  • srv_channels_add
  • srv_sync_products
  • srv_delete_channel_with_tool
  • srv_menu
  • srv_sync_channels
  • srv_content_lifecycle
  • srv_task_status_engine
  • srv_first_settings
  • srv_menu_filter
  • srv_wait_for_reposync
  • allcli_update_activationkeys
  • srv_enable_sync_products
  • srv_create_repository
  • srv_delete_channel_from_ui
  • srv_disable_local_repos_off
  • srv_add_rocky8_repositories
  • srv_channel_api
  • srv_clone_channel_npn

@mcalmer mcalmer merged commit fe381bf into uyuni-project:master Aug 22, 2023
14 checks passed
@mcalmer mcalmer deleted the fix-payg-check-and-refresh branch August 22, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant