Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Most Critical Systems list #7448

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

wweellddeerr
Copy link
Contributor

What does this PR change?

The setProxy method in SystemOverview was recently modified to accept a boolean value instead of Long. However, the query for loading the Most Critical Systems list was still passing the system ID for this method, causing errors during loading the list when a proxy was present.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/22343

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@wweellddeerr wweellddeerr requested a review from a team as a code owner August 22, 2023 11:48
@wweellddeerr wweellddeerr requested review from lucidd and parlt91 and removed request for a team August 22, 2023 11:48
@wweellddeerr wweellddeerr merged commit 43b4a14 into uyuni-project:master Aug 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants