move configuration done during first installation from rpm to mgr-setup script #7452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the container world the hostname is private to the cluster and could even contain random parts. This change avoids confusion between the FQDN and HOST variables and offers a clean code path for containers.
Checking the socket doesnt work in the container world, using the tool coming with postgres is much cleaner and works in both cases.
When running the setup in a container running on kubernetes we don't have control on the hostname the user knows about. Rather that relying on getting it from the system, allow reading it from the setup input file.
When running the setup in a container we want to avoid the setup_env.sh script and read the values from variables.
Running mgr-bootstrap in a containerized server cannot assume the hostname is the user-facing FQDN.
The helm chart intentionnaly doesn't deploy the PersistentVolumes and the SSL certificates for now. The documentation has also been adapted to use the helm chart. From now on the pod is running as a deployment
Document two different options to setup SSL for Uyuni server on k8s: using `rhn-ssl-tool` and manual certificates configuration or using `cert-manager` with automatically generated CA and certificates.
Since kubernetes uses the pod name as hostname the hostname ahdn hostname -f returns non-sense on such servers. Use the java.hostname from the rhn.conf as it has to be set to the publicly visible FQDN anyway.
We don't want to get the internal IP address of the server container, but the public one of the host, so use run_local.
The server hostname cannot be used in a kubernetes container as it is set to the pod name, the FQDN and hostname need to be used from `rhn.conf`
Enable monitoring in the container image to avoid the need of a few more volumes.
- curl -O always stores file to its filename. When using wget if the file exists it will append .1 and so on to prevent overwriting local file
mbussolotto
force-pushed
the
post_check
branch
from
0afcdba
to
698504e
Compare
mbussolotto
changed the title
mbussolotto
force-pushed
the
post_check
branch
2 times, most recently
from
cb4be58
to
8b360d7
Compare
When the report database is installed on the server we don't need and can't use SSL to connect to it using localhost hostname. This comes in handy to avoid hairpin requests in the container setup.
Under some circumstances like updating older unconfigured SUMA system, tomcat.xml was not configured properly as source tomcat.xml was not configured. Instead of relying if we are doing rpm update or new install, check status or rhn.conf file.
mbussolotto
force-pushed
the
post_check
branch
from
20a70c0
to
7ed7609
Compare
mbussolotto
force-pushed
the
server-container
branch
from
5b20b06
to
442207c
Compare
srbarrios
reviewed
Aug 30, 2023
| - features/core/srv_create_repository.feature | ||
| - features/reposync/srv_create_repository.feature |
There was a problem hiding this comment.
Uhm, I'm not sure about this change. Maybe better have this kind of change in a different PR?
|
closing the PR. changes no longer require |
ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
move configuration done during first installation from rpm to mgr-setup script
GUI diff
No difference.
Before:
After:
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE
Links
Fixes https://github.com/SUSE/spacewalk/issues/22091
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: