Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hostname rename feature #7474

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Aug 29, 2023

What does this PR change?

This PR fixes the test of hostname rename feature, where the cleanup was not working, and was making all subsequent feature tests fail.

It also adds idempotency, and a smoke test on the renamed server.

Links

Fixes: https://github.com/SUSE/spacewalk/issues/22323
Ports:

  • 4.3: cannot port as the "refresh" parameter of get_target is not implemented yet:
# Get the Twopence node passing the host (includes lazy initialization)
def get_target(host)
  node = $node_by_host[host]
  node = twopence_init(host) if node.nil?
  node
end

To be clarified with Oscar.

Changelogs

  • No changelog needed

@Bischoff Bischoff merged commit 7379f75 into uyuni-project:master Aug 29, 2023
8 checks passed
@Bischoff Bischoff deleted the fix-rename-test branch September 5, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants