Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE: Rename array constants #7477

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Aug 30, 2023

What does this PR change?

This will rename 2 of our constants to better match what they are actually defining.

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Cucumber tests were added

  • DONE

Links

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

This will rename 2 of our constants to better match what they are
actually defining.

Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
@Bischoff Bischoff self-requested a review August 30, 2023 13:27
@nodeg nodeg merged commit e9d74f7 into uyuni-project:master Aug 30, 2023
11 checks passed
@nodeg nodeg deleted the rename-constants branch August 30, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants