Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow our conventions for step names #7497

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Follow our conventions for step names #7497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testsuite/documentation/cucumber-steps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ The radio button can be identified by name, id or label text.
* Make sure a radio button is checked

```gherkin
Then radio button "radio-comma" is checked
Then radio button "radio-comma" should be checked
```

* Click on a given check box
Expand Down
8 changes: 4 additions & 4 deletions testsuite/features/secondary/allcli_software_channels.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Feature: Channel subscription via SSM
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
And I wait until I do not see "Loading..." text
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" is checked
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" should be checked
And I wait until I do not see "Loading..." text
And I should see "SLE15-SP4-Installer-Updates for x86_64" as unchecked

Expand Down Expand Up @@ -72,7 +72,7 @@ Feature: Channel subscription via SSM
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
And I wait until I do not see "Loading..." text
Then radio button "Fake Base Channel" is checked
Then radio button "Fake Base Channel" should be checked
And I wait until I do not see "Loading..." text
And I should see "Fake Child Channel" as checked

Expand Down Expand Up @@ -111,7 +111,7 @@ Feature: Channel subscription via SSM
Given I am on the Systems overview page of this "rhlike_minion"
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
Then radio button "Fake Base Channel" is checked
Then radio button "Fake Base Channel" should be checked

@deblike_minion
Scenario: System default channel can't be determined on the Debian-like minion
Expand Down Expand Up @@ -141,7 +141,7 @@ Feature: Channel subscription via SSM
Given I am on the Systems overview page of this "deblike_minion"
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
Then radio button "Fake-Deb-AMD64-Channel" is checked
Then radio button "Fake-Deb-AMD64-Channel" should be checked

@sle_minion
Scenario: Cleanup: subscribe the SLES minion back to previous channels
Expand Down
8 changes: 4 additions & 4 deletions testsuite/features/secondary/min_change_software_channel.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Feature: Assign child channel to a system
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
And I wait until I do not see "Loading..." text
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" is checked
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" should be checked
And I wait until I do not see "Loading..." text
And I should see "SLE15-SP4-Installer-Updates for x86_64" as unchecked

Expand All @@ -41,7 +41,7 @@ Feature: Assign child channel to a system
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
And I wait until I do not see "Loading..." text
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" is checked
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" should be checked
And I wait until I do not see "Loading..." text
And I check "SLE15-SP4-Installer-Updates for x86_64"
And I click on "Next"
Expand All @@ -61,7 +61,7 @@ Feature: Assign child channel to a system
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
And I wait until I do not see "Loading..." text
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" is checked
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" should be checked
And I wait until I do not see "Loading..." text
And I should see "SLE15-SP4-Installer-Updates for x86_64" as checked

Expand All @@ -83,7 +83,7 @@ Feature: Assign child channel to a system
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
And I wait until I do not see "Loading..." text
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" is checked
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" should be checked
And I wait until I do not see "Loading..." text
And I wait until I see "SLE15-SP4-Installer-Updates for x86_64" text
And I include the recommended child channels
Expand Down
2 changes: 1 addition & 1 deletion testsuite/features/secondary/min_project_lotus.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Feature: Project Lotus
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
And I wait until I do not see "Loading..." text
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" is checked
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" should be checked
And I wait until I do not see "Loading..." text
And I check "Custom Channel for SLES15SP4 PTFs"
And I click on "Next"
Expand Down
8 changes: 4 additions & 4 deletions testsuite/features/secondary/srv_change_task_schedule.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2021 SUSE LLC
# Copyright (c) 2021-2023 SUSE LLC
# Licensed under the terms of the MIT license.

@scope_recurring_actions
Expand All @@ -17,7 +17,7 @@ Feature: Change the schedule of a task
When I follow the left menu "Admin > Task Schedules"
And I follow "sandbox-cleanup-default"
Then I should see a "Friday" text
And radio button "weekly" is checked
And radio button "weekly" should be checked

Scenario: Change the schedule of task sandbox-cleanup-default to monthly
When I follow the left menu "Admin > Task Schedules"
Expand All @@ -28,7 +28,7 @@ Feature: Change the schedule of a task
Then I should see a "Schedule sandbox-cleanup-default has been updated." text
When I follow the left menu "Admin > Task Schedules"
And I follow "sandbox-cleanup-default"
Then radio button "monthly" is checked
Then radio button "monthly" should be checked

Scenario: Change the schedule of task sandbox-cleanup-default back to daily
When I follow the left menu "Admin > Task Schedules"
Expand All @@ -38,4 +38,4 @@ Feature: Change the schedule of a task
Then I should see a "Schedule sandbox-cleanup-default has been updated." text
When I follow the left menu "Admin > Task Schedules"
And I follow "sandbox-cleanup-default"
Then radio button "daily" is checked
Then radio button "daily" should be checked
4 changes: 2 additions & 2 deletions testsuite/features/secondary/srv_maintenance_windows.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2021-2022 SUSE LLC
# Copyright (c) 2021-2023 SUSE LLC
# Licensed under the terms of the MIT license.

# skip if container because we do not have a domain name and the
Expand Down Expand Up @@ -85,7 +85,7 @@ Feature: Maintenance windows
When I follow "Software" in the content area
And I follow "Software Channels" in the content area
And I wait until I do not see "Loading..." text
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" is checked
Then radio button "SLE-Product-SLES15-SP4-Pool for x86_64" should be checked
When I wait until I do not see "Loading..." text
Then I should see "SLE15-SP4-Installer-Updates for x86_64" as unchecked
When I check "SLE15-SP4-Installer-Updates for x86_64"
Expand Down
6 changes: 3 additions & 3 deletions testsuite/features/secondary/srv_users.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2015-2022 SUSE LLC
# Copyright (c) 2015-2023 SUSE LLC
# Licensed under the terms of the MIT license.
#
# 1) check users page
Expand Down Expand Up @@ -210,12 +210,12 @@ Feature: Manage users
And I choose ";"
And I click on "Save Preferences"
Then I should see a "Preferences modified" text
And radio button "radio-semicolon" is checked
And radio button "radio-semicolon" should be checked

Scenario: Cleanup: configure the CSV separator char to comma
Given I am authorized as "testing" with password "testing"
When I follow the left menu "Home > My Preferences"
And I choose ","
And I click on "Save Preferences"
Then I should see a "Preferences modified" text
And radio button "radio-comma" is checked
And radio button "radio-comma" should be checked
2 changes: 1 addition & 1 deletion testsuite/features/step_definitions/navigation_steps.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,7 @@
#
# Test if a radio button is checked
#
Then(/^radio button "([^"]*)" is checked$/) do |arg1|
Then(/^radio button "([^"]*)" should be checked$/) do |arg1|
raise "#{arg1} is unchecked" unless has_checked_field?(arg1)
end

Expand Down
Loading