Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC23] - B - Enable the downloading and synchronization of OVAL data #7509

Merged
merged 64 commits into from
Sep 5, 2024

Conversation

HoussemNasri
Copy link
Collaborator

@HoussemNasri HoussemNasri commented Sep 7, 2023

What does this PR change?

This is the implementation of the OVAL downloader component as stated in the linked RFC. Also adds support for SLE & Leap Micro OVAL-based CVE auditing.

TODO

  • Replace log.error() with log.debug()
  • Fix checkstyle errors

Useful Links

GUI diff

No difference.

Before:

After:
Screenshot from 2024-05-11 16-51-42

  • DONE

Documentation

Test coverage

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Suggested tests to cover this Pull Request
  • srv_change_password
  • srv_check_sync_source_packages
  • srv_check_reposync
  • min_bootstrap_api
  • min_salt_pkgset_beacon
  • srv_cobbler_distro
  • min_recurring_action
  • allcli_software_channels
  • srv_cobbler_profile
  • min_bootstrap_negative
  • buildhost_bootstrap
  • minssh_salt_install_package
  • min_deblike_remote_command
  • min_deblike_ssh
  • min_project_lotus
  • min_config_state_channel
  • min_deblike_salt
  • srv_disable_local_repos_off
  • min_change_software_channel
  • buildhost_docker_auth_registry
  • min_check_patches_install
  • srv_cobbler_sync
  • srv_users
  • srv_handle_config_channels_with_ISS_v2
  • min_retracted_patches
  • min_deblike_monitoring
  • srv_docker
  • srv_channels_add
  • srv_organization_credentials
  • srv_salt_download_endpoint
  • min_bootstrap_ssh_key
  • min_move_from_and_to_proxy
  • srv_reportdb
  • srv_wait_for_reposync
  • min_ssh_tunnel
  • srv_handle_software_channels_with_ISS_v2
  • min_deblike_salt_install_with_staging
  • srv_channel_api
  • min_salt_mgrcompat_state
  • srv_dist_channel_mapping
  • srv_patches_page
  • min_rhlike_monitoring
  • srv_user_configuration_salt_states
  • srv_push_package
  • min_config_state_channel_subscriptions
  • min_empty_system_profiles
  • min_deblike_salt_install_package
  • srv_create_repository
  • srv_payg_ssh_connection
  • min_action_chain
  • min_salt_formulas
  • min_monitoring
  • srv_user_preferences
  • srv_power_management
  • min_salt_openscap_audit
  • min_salt_minions_page
  • srv_power_management_redfish
  • srv_notifications
  • srv_monitoring
  • proxy_as_pod_basic_tests
  • srv_clone_channel_npn
  • srv_cobbler_buildiso
  • srv_manage_activationkey
  • min_salt_migration
  • min_salt_lock_packages
  • srv_first_settings
  • allcli_update_activationkeys
  • srv_user_api
  • buildhost_docker_build_image
  • min_salt_install_package
  • buildhost_osimage_build_image
  • srv_docker_cve_audit
  • srv_advanced_search
  • srv_docker_advanced_content_management
  • srv_task_status_engine
  • srv_power_management_api
  • srv_scc_user_credentials
  • allcli_reboot
  • srv_rename_hostname
  • srv_content_lifecycle
  • srv_delete_channel_from_ui
  • minkvm_guests
  • min_deblike_openscap_audit
  • proxy_register_as_minion_with_script
  • min_virthost
  • min_rhlike_remote_command
  • minssh_ansible_control_node
  • min_salt_software_states
  • srv_menu_filter
  • min_ansible_control_node
  • allcli_config_channel
  • min_rhlike_openscap_audit
  • srv_salt
  • min_cve_id_new_syntax
  • min_rhlike_salt
  • minssh_move_from_and_to_proxy
  • srv_logfile
  • allcli_software_channels_dependencies
  • min_activationkey
  • proxy_branch_network
  • srv_restart
  • srv_datepicker
  • allcli_sanity
  • min_docker_api
  • srv_manage_channels_page
  • minssh_bootstrap_api
  • allcli_system_group
  • min_salt_install_with_staging
  • proxy_retail_pxeboot_and_mass_import
  • min_bootstrap_script
  • min_salt_formulas_advanced
  • srv_enable_sync_products
  • min_cve_audit
  • sle_ssh_minion
  • srv_create_activationkey
  • srv_change_task_schedule
  • min_bootstrap_reactivation
  • allcli_overview_systems_details
  • srv_distro_cobbler
  • min_rhlike_salt_install_package_and_patch
  • srv_osimage
  • minssh_action_chain
  • srv_maintenance_windows
  • min_salt_user_states
  • srv_group_union_intersection
  • min_timezone
  • proxy_cobbler_pxeboot
  • srv_sync_products
  • min_config_state_channel_api
  • min_salt_minion_details
  • srv_check_channels_page
  • srv_menu
  • srv_mainpage
  • min_rhlike_ssh
  • sle_minion
  • srv_sync_channels
  • srv_add_rocky8_repositories
  • srv_activationkey_api
  • srv_delete_channel_with_tool
  • srv_custom_system_info
  • min_custom_pkg_download_endpoint
  • allcli_action_chain
  • srv_virtual_host_manager

Copy link
Contributor

github-actions bot commented Dec 3, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 3, 2023
@mcalmer mcalmer removed the Stale label Dec 3, 2023
Copy link
Contributor

github-actions bot commented Feb 2, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7509/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7509/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

HoussemNasri and others added 24 commits September 5, 2024 11:58
- If result is not empty, then server can be CVE audited normally otherwise a warning should be displayed indicating a lack of channels data and thus inaccuracies are expected.
- It doesn't bring much value + UI looks quite overloaded
Co-authored-by: Abid Mehmood <amehmood@suse.de>
- The 'scc' directory is not the best place to put this json file since it is not coming from SCC.
- The former does not accept a regex.
Signed-off-by: Pascal Arlt <parlt@suse.com>
Copy link
Contributor

@parlt91 parlt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did one last round of going through the PR and checking if everything is working. Could not detect any issues. From my side this is ready to merge.

@parlt91 parlt91 added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Sep 5, 2024
@deneb-alpha deneb-alpha merged commit 63c67f2 into uyuni-project:master Sep 5, 2024
27 checks passed
@parlt91 parlt91 mentioned this pull request Sep 6, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants