-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSOC23] - C - Implement a StAX parser for OVAL files #7510
base: master
Are you sure you want to change the base?
Conversation
Suggested tests to cover this Pull Request
|
8dc2d93
to
6d6dc0f
Compare
a279e94
to
7a5f2c7
Compare
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
@HoussemNasri @parlt91 i think this is still needed, right? |
Yes, the A and B pull requests need to be reviewed first before we can move to this one in case there was some changes that would affect this one (all PRs are kind of stacked on each other). Right now, pr A is under review. |
Than we better reopen this request |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
ddb3055
to
7f85762
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issues that were pointed out regarding styles and how they're used in the previous pull request are still present in this one. The comments are marked as resolved, but the issues have not been addressed, see e.g. #7509 (comment) and #7509 (comment). Please do not mark issues as resolved if they have not been addressed.
86f2025
to
9a8b53c
Compare
9a8b53c
to
07266bb
Compare
* @param bulkHandler an operation to applied on every bulk of parsed OVAL definitions. | ||
* */ | ||
public void parseDefinitionsInBulk(File ovalFile, OVALDefinitionsBulkHandler bulkHandler) { | ||
XMLInputFactory xmlInputFactory = XMLInputFactory.newInstance(); |
Check failure
Code scanning / SonarCloud
XML parsers should not be vulnerable to XXE attacks High
* @return an {@link OVALResources} object containing OVAL objects, states and tests. | ||
* */ | ||
public OVALResources parseResources(File ovalFile) { | ||
XMLInputFactory xmlInputFactory = XMLInputFactory.newInstance(); |
Check failure
Code scanning / SonarCloud
XML parsers should not be vulnerable to XXE attacks High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No frontend changes in the latest summa summarum changeset.
NOTE: Please start the review from commit 15624fb, the other commits are reviewed in #7509.
What does this PR change?
Introduce a StAX parser (instead of the current JAXB parser) for OVAL files to increase memory efficiency when parsing large OVAL files.
Useful Links
GUI diff
No difference.
Before:
After:
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE
Links
Fixes #
Tracks # add downstream PR, if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: