Improve Taskomatic by removing invalid triggers before start and enhancing logs #7523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Its core change is to add the
TaskoQuartzHelper.removeInvalidTriggers
method and call it before starting Taskomatic. This method detects and removes invalid triggers from the Quartz database. In some cases, the Quartz database can become inconsistent, with records in the main QRTZ_TRIGGERS table lacking corresponding entries in any of the possible detail property tables (QRTZ_CRON_TRIGGERS, QRTZ_SIMPLE_TRIGGERS, QRTZ_BLOB_TRIGGERS or QRTZ_SIMPROP_TRIGGERS).While the exact scenarios leading to this inconsistency may not be clear, this method provides a solution to prevent Taskomatic from failing to start, performing a cleanup of invalid triggers before starting the scheduler. See quartz-scheduler/quartz#85 for additional reference.
It also contains some additional logs for Taskomatic and includes database scripts to create a missing database table for Quartz:
qrtz_simprop_triggers
.GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests
DONE
Links
Fixes https://github.com/SUSE/spacewalk/issues/22195
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: