Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools updates are needed on Rocky 8 to install prometheus #7561

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Sep 19, 2023

What does this PR change?

Fixes test suite issue https://github.com/SUSE/spacewalk/issues/21393 (highstate fails when installing prometheus)

Links

Ports:

  • 4.3: not needed, updates_repo always added

Changelogs

  • No changelog needed

Copy link
Contributor

@vandabarata vandabarata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@vandabarata
Copy link
Contributor

ah but rubocop:

features/step_definitions/command_steps.rb:1174:56: C: Layout/SpaceAroundOperators: Surrounding space missing for operator :.
repositories = product == 'Uyuni' ? 'tools_pool_repo': 'tools_pool_repo tools_update_repo'

@raulillo82 raulillo82 merged commit 952315d into uyuni-project:master Sep 19, 2023
7 of 11 checks passed
@Bischoff Bischoff deleted the prometheus-highstate branch September 19, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants