Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Loggerhead log include error logs from third-party code #7598

Merged
merged 9 commits into from
Oct 5, 2023

Conversation

Etheryte
Copy link
Member

@Etheryte Etheryte commented Sep 28, 2023

What does this PR change?

Currently our global logger only logs errors and warns from our own code which means we crucially miss errors thrown from React etc. This PR binds our logger to the global console so we should see more information from debug logs.

Additionally I've added performance marks so it's easier to line up events if the client makes a performance recording for us. Otherwise you need to jump between our own logs and the recording to get the full picture.

(As a side effect, thanks to these changes I found a small bug in our login page where the locale was set too late so it was undefined for some scripts.)

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/22609

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

@parlt91 parlt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I imagine this will come in handy

@Etheryte Etheryte merged commit 67c5856 into uyuni-project:master Oct 5, 2023
14 of 20 checks passed
@Etheryte
Copy link
Member Author

Etheryte commented Oct 5, 2023

Note to self: this needs to be ported to 4.3 once the branch is unlocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants