Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman sql scripts selection #7604

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented Sep 29, 2023

What does this PR change?

This PR changes the logic of how the sql scripts are applied in the podman testsuite runner. Instead of listing just listing the directories with a find and relying on the list to be correctly sorted (which was not the case and cause the linked issue), it now starts from the directory <schema name>-<current version>-to-* and moves to the next one specified after the -to- part, looping until there are no further directories to pick up.

This should ensure the correct application of all the required sql scripts starting from the current schema version installed inside the podman container.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: only changes to the test infrastracture

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/22617

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mackdk mackdk force-pushed the fix-podman-sql-scripts-selection branch from 158304a to e8fe68d Compare September 29, 2023 12:24
@mackdk
Copy link
Contributor Author

mackdk commented Sep 29, 2023

@jordimassaguerpla This PR fixes the sql update issue, but there is now another test failing. I have no clue what the problem is though

@mackdk mackdk marked this pull request as ready for review October 2, 2023 07:48
@mackdk mackdk requested a review from a team as a code owner October 2, 2023 07:48
@mackdk
Copy link
Contributor Author

mackdk commented Oct 2, 2023

> @jordimassaguerpla This PR fixes the sql update issue, but there is now another test failing. I have no clue what the problem is though

Seems the error is fixed now

@mackdk mackdk mentioned this pull request Oct 2, 2023
12 tasks
@mackdk mackdk requested a review from mikeletux October 2, 2023 10:11
@jordimassaguerpla jordimassaguerpla merged commit d2eb86d into uyuni-project:master Oct 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants