-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow Google GSON 2.10 or higher due to removed methods #7614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment Stefan, what's your take?
Co-authored-by: Marina Latini <marina.latini@suse.com>
👋 Hello! Thanks for contributing to our project. Happy hacking! |
Co-authored-by: Marina Latini <marina.latini@suse.com>
Thanks a lot @deneb-alpha , your suggestion works fine! |
let's wait for the tests, but I think in this way we should be safe. |
notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
What does this PR change?
Disallow Google GSON 2.10 or higher due to removed methods.
Salt communication fails otherwise with a class not found exception when accessing the Salt keys page.
(GSON 2.10 is available in the Enteprise Linux 9 repos)
Remove minimum GSON requirement. What would install a lower version?
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Package build tested on Copr for epel-9-x86_64
Links
Fixes #
Tracks # add downstream PR, if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: