Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Google GSON 2.10 or higher due to removed methods #7614

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

sbluhm
Copy link
Contributor

@sbluhm sbluhm commented Sep 30, 2023

What does this PR change?

  1. Disallow Google GSON 2.10 or higher due to removed methods.
    Salt communication fails otherwise with a class not found exception when accessing the Salt keys page.
    (GSON 2.10 is available in the Enteprise Linux 9 repos)

  2. Remove minimum GSON requirement. What would install a lower version?

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

Package build tested on Copr for epel-9-x86_64

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment Stefan, what's your take?

java/spacewalk-java.spec Outdated Show resolved Hide resolved
java/spacewalk-java.spec Outdated Show resolved Hide resolved
Co-authored-by: Marina Latini <marina.latini@suse.com>
@github-actions
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7614/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7614/checks.
See the troubleshooting guide if you need any help.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Co-authored-by: Marina Latini <marina.latini@suse.com>
@sbluhm
Copy link
Contributor Author

sbluhm commented Oct 30, 2023

Thanks a lot @deneb-alpha , your suggestion works fine!

@deneb-alpha
Copy link
Contributor

Thanks a lot @deneb-alpha , your suggestion works fine!

let's wait for the tests, but I think in this way we should be safe.

@deneb-alpha
Copy link
Contributor

notes:

  • failure on: acceptance-tests-secondary-parallel / test-uyuni (2) / test-uyuni (pull_request) is unrelated
  • failure on: acceptance-tests-secondary-parallel / test-uyuni (5) / test-uyuni (pull_request) is unrelated

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@deneb-alpha deneb-alpha merged commit 7517781 into uyuni-project:master Oct 31, 2023
13 of 14 checks passed
@sbluhm sbluhm deleted the googlegson branch October 31, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants