-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package source to meet tito requirement #7615
Conversation
@cbbayburt , can you please review this one? Would love to have it in before the next release. Big thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sbluhm. LGTM 👍
Let's get a release engineer to have a look as well.
Meanwhile, please rebase your branch so the tests run again.
@deneb-alpha, can you please review this one? Would love to have it in before the next release. Big thanks! |
@raulillo82 maybe you can also have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thanks
What does this PR change?
Tito requires to list the package source as %{name}-%{version}.tar.gz
If an existing source is set, tito downloads the package instead of using the git structure. This stops the package from building on Fedora Copr (the download has a different folder structure).
(see Tito man page at https://github.com/rpm-software-management/tito/blob/9fd0c5a2c7c801f3186a0d7c836ed7278fdcff0c/tito.8.asciidoc?plain=1#L55)
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Build manually tested on copr epel-9-x86_64.
Links
Fixes #
Tracks # add downstream PR, if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: