Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package source to meet tito requirement #7615

Merged
merged 6 commits into from
Oct 30, 2023

Conversation

sbluhm
Copy link
Contributor

@sbluhm sbluhm commented Sep 30, 2023

What does this PR change?

Tito requires to list the package source as %{name}-%{version}.tar.gz
If an existing source is set, tito downloads the package instead of using the git structure. This stops the package from building on Fedora Copr (the download has a different folder structure).

(see Tito man page at https://github.com/rpm-software-management/tito/blob/9fd0c5a2c7c801f3186a0d7c836ed7278fdcff0c/tito.8.asciidoc?plain=1#L55)

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

Build manually tested on copr epel-9-x86_64.

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@sbluhm sbluhm requested a review from a team as a code owner September 30, 2023 10:58
@sbluhm sbluhm requested review from cbbayburt and removed request for a team September 30, 2023 10:58
@sbluhm sbluhm changed the title Titofix Update package source to meet tito requirement Oct 2, 2023
@sbluhm
Copy link
Contributor Author

sbluhm commented Oct 12, 2023

@cbbayburt , can you please review this one? Would love to have it in before the next release. Big thanks!

Copy link
Contributor

@cbbayburt cbbayburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sbluhm. LGTM 👍

Let's get a release engineer to have a look as well.
Meanwhile, please rebase your branch so the tests run again.

@sbluhm
Copy link
Contributor Author

sbluhm commented Oct 23, 2023

@deneb-alpha, can you please review this one? Would love to have it in before the next release. Big thanks!

@mcalmer
Copy link
Contributor

mcalmer commented Oct 29, 2023

@raulillo82 maybe you can also have a look

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks

@deneb-alpha deneb-alpha merged commit bc579fd into uyuni-project:master Oct 30, 2023
15 checks passed
@sbluhm sbluhm deleted the titofix branch December 12, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants