Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include reboot_suggested and restart_suggested booleans in errata.getDetails response #7617

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

HoussemNasri
Copy link
Collaborator

@HoussemNasri HoussemNasri commented Oct 1, 2023

What does this PR change?

See title and linked issue.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: XML-RPC API documentation is generated automatically AFAIK.

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes #3733

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Suggested tests to cover this Pull Request
  • allcli_sanity
  • min_salt_install_package
  • srv_check_channels_page
  • srv_check_sync_source_packages
  • proxy_cobbler_pxeboot
  • srv_content_lifecycle
  • proxy_as_pod_basic_tests
  • min_rhlike_salt_install_package_and_patch
  • srv_patches_page
  • min_action_chain
  • minssh_action_chain
  • srv_rename_hostname
  • min_check_patches_install
  • srv_monitoring
  • min_cve_audit
  • min_retracted_patches
  • srv_clone_channel_npn
  • min_salt_install_with_staging
  • proxy_branch_network
  • min_cve_id_new_syntax
  • srv_first_settings

@Etheryte Etheryte removed their request for review October 2, 2023 09:33
@HoussemNasri HoussemNasri force-pushed the errata-reboot-suggested branch 2 times, most recently from 74abbc2 to c12528e Compare October 7, 2023 09:50
@cbbayburt
Copy link
Contributor

Thanks, @HoussemNasri. LGTM 👍

Please rebase your branch so the acceptance tests run again on newer code. They should pass now.

@cbbayburt cbbayburt merged commit 141a724 into uyuni-project:master Oct 11, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement API to gather whether an erratum required a reboot
2 participants