Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set BuildTag for Dockerfile and Chart.yaml using push-packages-to-obs.sh #7620

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Oct 2, 2023

What does this PR change?

helm enforces semverv2 on the image tags on OCI repositories. This means that we need one to pull the chart from the repository generated by OBS. For the testsuite we need to add the semantic version as tag on Helm Charts only.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: proxy images additional tags removed

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

helm enforces semverv2 on the image tags on OCI repositories. This means
that we need one to pull the chart from the repository generated by OBS.
For the testsuite we need to add the semantic version as tag on Helm Charts only.
@cbosdo cbosdo requested a review from a team as a code owner October 2, 2023 07:40
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@raulillo82 raulillo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deneb-alpha deneb-alpha removed the request for review from juliogonzalez October 2, 2023 16:39
@cbosdo cbosdo merged commit 146a0e6 into uyuni-project:master Oct 3, 2023
7 checks passed
@cbosdo cbosdo deleted the tag-cleanup branch October 3, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants