Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve datetimepicker time input #7625

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

Etheryte
Copy link
Member

@Etheryte Etheryte commented Oct 2, 2023

What does this PR change?

Currently, the picker works somewhat counterintuitively when you omit a ":" or leave off a trailing number, sometimes producing odd values which are not instantly clear why they happened. This PR moves the time parsing over to moment, adds test coverage, and other small improvements.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Unit tests were added

  • DONE

Links

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@Etheryte Etheryte requested a review from a team as a code owner October 2, 2023 14:19
@Etheryte Etheryte requested review from cbbayburt and removed request for a team October 2, 2023 14:19
Copy link
Contributor

@cbbayburt cbbayburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

web/html/src/components/datetime/DateTimePicker.tsx Outdated Show resolved Hide resolved
@Etheryte Etheryte merged commit 167fc28 into uyuni-project:master Oct 4, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants