Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite: update test containers to leap 15.5 #7648

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Testsuite: update test containers to leap 15.5 #7648

merged 1 commit into from
Oct 31, 2023

Conversation

jordimassaguerpla
Copy link
Contributor

@jordimassaguerpla jordimassaguerpla commented Oct 5, 2023

What does this PR change?

Testsuite: update test containers to leap 15.5

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • No tests
  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/22694

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some remarks

@@ -1,4 +1,4 @@
FROM opensuse/leap:15.4
FROM opensuse/leap:15.5
RUN zypper ref -f && \
zypper -n ar --no-gpgcheck http://download.opensuse.org/repositories/systemsmanagement:/sumaform:/tools/openSUSE_Leap_15.4/ tools && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zypper -n ar --no-gpgcheck http://download.opensuse.org/repositories/systemsmanagement:/sumaform:/tools/openSUSE_Leap_15.4/ tools && \
zypper -n ar --no-gpgcheck http://download.opensuse.org/repositories/systemsmanagement:/sumaform:/tools/openSUSE_Leap_15.5/ tools && \

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordimassaguerpla I also have a doubt on the list of installed packages.
postgresql-devel -> this should still be version 14 because we didn't bump the postgresql version.

@@ -1,4 +1,4 @@
FROM registry.suse.com/bci/bci-init:15.4
FROM registry.suse.com/bci/bci-init:15.5
# from https://raw.githubusercontent.com/rjmateus/uyuni-container/main/uyuni/Dockerfile

RUN zypper ar -G http://download.opensuse.org/update/leap/15.4/backports/ backports_update_repo
Copy link
Contributor

@deneb-alpha deneb-alpha Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN zypper ar -G http://download.opensuse.org/update/leap/15.4/backports/ backports_update_repo
RUN zypper ar -G http://download.opensuse.org/update/leap/15.5/backports/ backports_update_repo

and the same applies to the other repos mentioning 15.4 instead of 15.5

RUN zypper ar -G http://download.opensuse.org/distribution/leap/15.4/repo/oss/ os_pool_repo
RUN zypper ar -G http://download.opensuse.org/update/leap/15.4/oss/ os_update_repo
RUN zypper ar -G http://download.opensuse.org/update/leap/15.4/sle/ sle_update_repo

Sorry, I can't add a suggestion for changing also those

@@ -1,4 +1,4 @@
FROM registry.suse.com/bci/bci-init:15.4
FROM registry.suse.com/bci/bci-init:15.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why here we are using a SLE image instead openSUSE Leap. I know that the bci-init is based on tumbleweed, not on Leap, but using SLE as base and adding Leap repos sounds weird to me

@github-actions
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7648/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7648/checks.
See the troubleshooting guide if you need any help.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@jordimassaguerpla
Copy link
Contributor Author

@deneb-alpha : Thanks for your feedback. I have addressed all your revisions.

Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.com>
@jordimassaguerpla jordimassaguerpla merged commit 7154451 into uyuni-project:master Oct 31, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants