Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json script with missing products #7653

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

ktsamis
Copy link
Contributor

@ktsamis ktsamis commented Oct 6, 2023

What does this PR change?

We were missing LTSS for 4.2 proxy and server and web scripting for 4.3. Web scripting is used for tomcat for example.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes no issue
Tracks no PR

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we have some discrepancies with the / at the end.

@nodeg
Copy link
Member

nodeg commented Oct 6, 2023

Ok, I see you fixed that while I was writing my review comment.

@ktsamis
Copy link
Contributor Author

ktsamis commented Oct 6, 2023

Yes sorry, I realised after you said about the first, I checked the end as well. I don't know where my head is at, two mistakes in one line. Thanks for the review :)

@ktsamis ktsamis merged commit 973dcfd into uyuni-project:master Oct 6, 2023
6 of 8 checks passed
@ktsamis ktsamis deleted the bvscript branch October 6, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants