Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payg cert import #7668

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Oct 10, 2023

What does this PR change?

The payg import script look for the RMT CA certificate in the following order:

  1. /usr/share/pki/trust/anchors/
  2. /etc/pki/trust/anchors/

This order seems to be wrong as updates to certificates are applied to /etc/ only.
This cause old certificates are still available in /usr/... and gets imported (first match win)
while the new certificates in /etc/ are ignored.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Port of https://github.com/SUSE/spacewalk/pull/22695

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mcalmer mcalmer requested a review from a team as a code owner October 10, 2023 14:43
@mcalmer mcalmer requested review from mackdk and removed request for a team October 10, 2023 14:43
@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request

@mcalmer mcalmer merged commit 7dc5da8 into uyuni-project:master Oct 12, 2023
16 checks passed
@mcalmer mcalmer deleted the fix-payg-cert-import branch October 12, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants