Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignement, reenable disabled code #7687

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Oct 15, 2023

What does this PR change?

This PR fixes the most obvious issues in products page:

  • align columns
  • @uyuyni -> @uyuni for SLE micro 5.2
  • re-enable disabled code for SLE micro 5.4
  • (4.3 branch only) remove duplicated code for Debian 12

This PR does not fix:

  • duplicate scenario names
  • many undefined method 'map' for true:TrueClass errors at run time,
    i.e. the web driver does not seem able to recover after an error

Links

Ports:

Changelogs

  • No changelog needed

@nodeg nodeg self-requested a review October 15, 2023 20:35
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much, Eric!

@Bischoff Bischoff merged commit 73bd92f into uyuni-project:master Oct 16, 2023
7 of 8 checks passed
@Bischoff Bischoff deleted the fix-products-obvious-errors branch November 2, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants