Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move server rename to finishing stage #7696

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

maximenoel8
Copy link
Contributor

What does this PR change?

Move server rename to finishing stage

GUI diff

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many more files touched that are not related to moving the hostname rename test to the very end.

@maximenoel8
Copy link
Contributor Author

I didn't start from the correct branch, sorry !

Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, other than that LGTM. Thank you, Maxime.

testsuite/run_sets/finishing.yml Outdated Show resolved Hide resolved
Co-authored-by: Dominik Gedon <dgedon@suse.de>
@maximenoel8 maximenoel8 merged commit ba8a8b7 into uyuni-project:master Oct 18, 2023
6 of 7 checks passed
@maximenoel8 maximenoel8 deleted the fix_certificate_issue branch October 18, 2023 08:56
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants