Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for filelock #7698

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Wait for filelock #7698

merged 2 commits into from
Oct 18, 2023

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Oct 17, 2023

What does this PR change?

To prevent conflicting scc sync tasks to fight for the lock, wait some time for it.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: manual tried

  • DONE

Links

Port of https://github.com/SUSE/spacewalk/pull/22790

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mcalmer mcalmer requested a review from a team as a code owner October 17, 2023 14:45
@mcalmer mcalmer requested review from wweellddeerr and removed request for a team October 17, 2023 14:45
@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • srv_sync_channels
  • srv_sync_products
  • srv_task_status_engine

Copy link
Contributor

@wweellddeerr wweellddeerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcalmer mcalmer merged commit ab92bb4 into uyuni-project:master Oct 18, 2023
13 of 15 checks passed
@mcalmer mcalmer deleted the wait-for-filelock branch October 18, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants