Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement strict mode checkbox for sync runs #7708

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Implement strict mode checkbox for sync runs #7708

merged 3 commits into from
Dec 21, 2023

Conversation

r-richardson
Copy link
Contributor

@r-richardson r-richardson commented Oct 18, 2023 •
edited
Loading

What does this PR change?

see: https://github.com/SUSE/spacewalk/issues/22420

  1. Added no-strict parameter handling in SyncRepositoriesAction.java, RepoSyncTask.java, and spacewalk-repo-sync.
  2. Introduced a checkbox in syncrepos.jsp for user control, with accompanying text in StringResource_en_US.xml.
  3. Adjusted RepoSync class in reposync.py to process the new parameter.

Also added a cucumber test, and did manual testing to ensure correct flag passing and expected behavior when toggling no-strict mode from the frontend.

GUI diff

Screenshot from 2023-10-18 16-40-18

Documentation

Test coverage

Changelogs

  • No changelog needed

Re-run a test

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

Suggested tests to cover this Pull Request
  • allcli_update_activationkeys
  • srv_create_repository
  • srv_task_status_engine
  • srv_sync_products
  • srv_enable_sync_products
  • srv_sync_channels

@r-richardson r-richardson force-pushed the reposync_package_deletion branch 2 times, most recently from 459d1d7 to 0aaf18a Compare October 18, 2023 16:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7708/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7708/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@r-richardson r-richardson force-pushed the reposync_package_deletion branch 4 times, most recently from 24f5ffb to 0227d0e Compare October 27, 2023 11:35
@r-richardson r-richardson force-pushed the reposync_package_deletion branch 3 times, most recently from 2ce4c27 to 1e98b2c Compare December 12, 2023 18:27
@r-richardson r-richardson force-pushed the reposync_package_deletion branch 4 times, most recently from 1b04a1c to 572469d Compare December 14, 2023 12:20
@r-richardson r-richardson changed the title WIP: Implement strict mode checkbox for sync runs. Implement strict mode checkbox for sync runs. Dec 15, 2023
@r-richardson r-richardson changed the title Implement strict mode checkbox for sync runs. Implement strict mode checkbox for sync runs Dec 15, 2023
@r-richardson r-richardson marked this pull request as ready for review December 15, 2023 13:18
@r-richardson r-richardson requested a review from a team as a code owner December 15, 2023 13:18
srbarrios
srbarrios requested changes Dec 17, 2023
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of Cucumber tests! I added few comments. I will be out on Monday, but we can discuss it on Tuesday.

testsuite/features/reposync/srv_sync_repo_sync.feature Outdated Show resolved Hide resolved
testsuite/features/reposync/srv_sync_repo_sync.feature Outdated Show resolved Hide resolved
testsuite/features/reposync/srv_sync_repo_sync.feature Outdated Show resolved Hide resolved
testsuite/features/reposync/srv_sync_repo_sync.feature Outdated Show resolved Hide resolved
testsuite/features/step_definitions/command_steps.rb Outdated Show resolved Hide resolved
testsuite/features/reposync/srv_sync_repo_sync.feature Outdated Show resolved Hide resolved
testsuite/features/step_definitions/command_steps.rb Outdated Show resolved Hide resolved
testsuite/features/step_definitions/command_steps.rb Outdated Show resolved Hide resolved
testsuite/features/step_definitions/navigation_steps.rb Outdated Show resolved Hide resolved
mcalmer
mcalmer requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about the changelogs. When you read this as an admin, what do you want to know about this change and the new feature. It is ok, if the entry is a bit longer.

java/code/webapp/WEB-INF/pages/channel/manage/syncrepos.jsp Outdated Show resolved Hide resolved
java/spacewalk-java.changes.rrichardson.reposync_package_deletion Outdated Show resolved Hide resolved
@r-richardson
Implement strict mode checkbox for sync runs.
8df6154 
see: SUSE/spacewalk#22420

This PR includes:

1. Added no-strict parameter handling in SyncRepositoriesAction.java, RepoSyncTask.java, and spacewalk-repo-sync.
2. Introduced a checkbox in syncrepos.jsp for user control, with accompanying text in StringResource_en_US.xml.
3. Adjusted RepoSync class in reposync.py to process the new parameter.

Tested the functionality to ensure correct flag passing and expected behavior on toggling strict mode from the frontend.
@r-richardson
Add cucumber test for strict mode functionality
c32b546
agraul
agraul approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@agraul agraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes LGTM

python/spacewalk/satellite_tools/reposync.py Show resolved Hide resolved
python/spacewalk/spacewalk-backend.changes.rrichardson.reposync_package_deletion Outdated Show resolved Hide resolved
@r-richardson r-richardson force-pushed the reposync_package_deletion branch 5 times, most recently from 5330990 to e1b2eba Compare December 19, 2023 12:59
mackdk
mackdk approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mackdk mackdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java code change looks good.

@r-richardson r-richardson added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Dec 20, 2023
@mcalmer mcalmer merged commit 79726b8 into uyuni-project:master Dec 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcalmer mcalmer mcalmer approved these changes

@mackdk mackdk mackdk approved these changes

@srbarrios srbarrios srbarrios approved these changes

@agraul agraul agraul approved these changes

@mikeletux mikeletux Awaiting requested review from mikeletux

Assignees
No one assigned
Labels
API java_lint_checkstyle java_pgsql_tests java merge-candidate Meaning it needs to be considered for merging when the master branch is frozen needs-translation old-ui ruby_rubocop test-framework testing webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r-richardson @mcalmer @mackdk @srbarrios @agraul