Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recurring action test #7709

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fix recurring action test #7709

merged 2 commits into from
Oct 19, 2023

Conversation

maximenoel8
Copy link
Contributor

What does this PR change?

The software update text is taking few seconds to show up. Because we are using should and not wait, we are expecting the text to be immediately visible. Change the should see to wait for text.

Links

https://github.com/SUSE/spacewalk/issues/22735

  • DONE

Changelogs

  • No changelog needed

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@maximenoel8 maximenoel8 requested a review from a team as a code owner October 19, 2023 03:28
nodeg
nodeg approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, Maxime!

@Bischoff Bischoff self-requested a review October 19, 2023 08:14
@maximenoel8 maximenoel8 merged commit 0f21406 into uyuni-project:master Oct 19, 2023
9 checks passed
@maximenoel8 maximenoel8 deleted the fix_recurrint_action_test branch October 19, 2023 08:21
@Bischoff
Copy link
Contributor

Please do not forget the ports (if any).

r-richardson pushed a commit to r-richardson/uyuni that referenced this pull request Oct 26, 2023
@maximenoel8 @r-richardson
Fix recurring action test (uyuni-project#7709)
308ab99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bischoff Bischoff Bischoff approved these changes

@srbarrios srbarrios srbarrios approved these changes

@nodeg nodeg nodeg approved these changes

Assignees
No one assigned
Labels
ruby_rubocop secondary-features testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximenoel8 @Bischoff @srbarrios @nodeg